Repository navigation
models: remove redundant ggml_cont calls now supported by CUDA unary kernels - #30198
Merged
Merged
Conversation
CISC
approved these changes
Oct 9, 2026
Member
Member
|
Also, there are more that are not marked with llama.cpp/src/models/dflash.cpp Line 340 in 3b75c63 |
Contributor
Author
Removed the redundant Regarding |
CISC
reviewed
Oct 10, 2026
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@huggingface.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is a follow-up to #29781. That PR added support for unary operations on non-contiguous tensors in CUDA. With that support now upstream, this PR cleans up redundant
ggml_cont/ggml_cont_2dallocations and their associatedTODOcomments across affected models.Removing these intermediate copies simplifies the compute graphs and avoids unnecessary memory bandwidth overhead during the forward pass.
Changes
src/models/delta-net-base.cpp:ggml_contong_lastbeforeggml_expinbuild_delta_net_chunking.src/models/qwen3next.cpp:ggml_cont_2dongatebeforeggml_sigmoidinbuild_layer_attn.ggml_contonbbeforeggml_sigmoidinbuild_layer_attn_linear.ggml_cont_2dongatebeforeggml_sigmoidingraph_mtp::graph_mtp.Requirements