Repository navigation
musa: use the tile lightning indexer kernel - #30080
Merged
ServeurpersoCom merged 1 commit intoOct 7, 2026
Merged
ServeurpersoCom merged 1 commit into
ServeurpersoCom merged 1 commit into
Conversation
Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
CISC
approved these changes
Oct 7, 2026
ServeurpersoCom
approved these changes
Oct 7, 2026
ServeurpersoCom
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for testing on real hardware! Limiting the head passes to arch 21 keeps CUDA and HIP on the merged kernel, and the red jobs are unrelated
Contributor
|
@ServeurpersoCom let a CUDA maintainer merge CUDA PRs. Thanks |
Contributor
|
Got it, sorry about that, I'll leave CUDA merges to you from now on. |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up to #29901 and #29990. Only MUSA arch 21 caps static shared memory at 28 KB. With mcc 5.2.0, mp_22 allows 72 KB and mp_31 allows 192 KB, so the 33 KB tile kernel from #29901 only fails to build on mp_21.
This brings the tile kernel back on MUSA. It takes the head pass staging from 8b84aec (thanks @ServeurpersoCom) and limits the two heads per pass to
__MUSA_ARCH__ < 220:Testing Done
Built with the default
MUSA_ARCHITECTURES(21;22;31) inmusa_sdk:5.2.0-devel-ubuntu22.04-s5000.test-backend-ops -o LIGHTNING_INDEXERpasses 192/192 on MTT S5000 and MTT S80.test-backend-ops perf -o LIGHTNING_INDEXER -p 'nh=4,kv=65536,nb=2048,ns=1,nm=1,type_K=f16', time in ms (S5000 is the median of 3 runs):nb=1 is unchanged, it still uses the vector kernel.
test-backend-ops perf -o LIGHTNING_INDEXER -p 'nh=4,kv=65536,nb=(512|2048),ns=1,', time in ms (S5000 is the median of 3 runs):Additional information
Requirements