Repository navigation
ci : skip container re-tagging when Require Docker is disabled - #30008
Merged
Merged
Conversation
Assisted-by: pi:llama.cpp/Qwen3.8-Flash-Next
github-actions
Bot
added
the
devops
ggerganov
marked this pull request as ready for review
October 5, 2026 17:50
CISC
approved these changes
Oct 5, 2026
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 8, 2026
…org#30008) Assisted-by: pi:llama.cpp/Qwen3.8-Flash-Next (cherry picked from commit c250304)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up to #29989: the
require_dockerflag disabled the container image check, but the "Re-tag container images with release version" step still ran unconditionally and aborted the job when the nightly images did not exist (see run 37344417952, which failed after the release was already created).Changes:
.github/workflows/make-release.yml: skip the re-tag step whenrequire_dockerisfalse; when it runs, keep going on a missing image and report all missing tags at the end instead of dying on the first onescripts/make-release-checks.sh: clarify thatREQUIRE_DOCKER=falsealso skips re-taggingRequirements