Repository navigation
CUDA: make the alloc_deps check batch independent - #29986
Merged
Merged
Conversation
github-actions
Bot
added
ggml
ggerganov
approved these changes
Oct 5, 2026
ServeurpersoCom
approved these changes
Oct 5, 2026
ServeurpersoCom
left a comment
ServeurpersoCom
left a comment
Contributor
There was a problem hiding this comment.
Tested on a single RTX PRO 6000 with Qwen3.6-35B-A3B Q8_0 (shared expert fusion active) and the prompt from #29980: master aborts under GGML_SCHED_DEBUG_REALLOC=1 and this PR fixes it, prefill and TG are unchanged and greedy output is identical. The 2x prefill drop does not show on one GPU, so it is likely the multi-GPU sync cost on each re-reserve.
Minor: the match now drops the batch independent checks of should_fuse_mul_mat_vec_q too (Pascal cc, F32 types, padding), so graph_optimize can reorder for a fusion that never runs, splitting that function into a static part and a batch part would keep them.
1 task
5 tasks
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 8, 2026
Fixes ggml-org#29980 (cherry picked from commit e117148)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29980
Overview
Additional information
Requirements