Repository navigation
ui: apply ui_settings on first visit in router mode - #29668
Merged
Merged
Conversation
Contributor
|
Makes sense to me. Automated browser-use testing with Astra was able to confirm the bug on main and that this PR fixes it. |
allozaur
approved these changes
Oct 5, 2026
ServeurpersoCom
approved these changes
Oct 5, 2026
ServeurpersoCom
left a comment
ServeurpersoCom
left a comment
Contributor
There was a problem hiding this comment.
LGTM, the router main instance answers /props with empty params so the first visit pass was never reached, this is the same root cause reported in #28077.
Contributor
|
This only fires on a fresh browser (no stored config), existing user settings are never overwritten and later visits keep the current behavior. |
feal87
added a commit
to feal87/myllama.cpp
that referenced
this pull request
Oct 8, 2026
Upstream brings CUDA top-k/argsort/mmq fixes (PR ggml-org#28713, ggml-org#29953, ggml-org#30147, ggml-org#29453), a DFlash output-head fix (ggml-org#30111) and a UI fix (ggml-org#29668). Conflicts and resolution: - top-k.cu / argsort.cu: upstream reworked the top-k selection and the same radix path the fork added. Take upstream's shape-based dispatch and int64_t fixes, keep the fork workspace cap in the shared ggml_cuda_chunk_nrows (GGML_CUDA_ARGSORT_CHUNK_MB) and the fork benchmark-only GGML_CUDA_TOPK_IMPL selector used by bench-topk.py. - mmq.cu: upstream PR ggml-org#29953 fixes the same mul_mat_id padding over-read the fork patched in 1386ec2, but sizes the padding from the chosen J tile in both branches. Take upstream's version. - test-backend-ops.cpp: keep the fork GGML_TOPK_BENCH shapes and add upstream's chunk-spanning cases. Assisted-by: pi (deepseek-flash)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
In router mode, settings from
--ui-config-filedon't show up on the first visit to the web UI until you click "Reset to default". The router's main process returns emptydefault_generation_settings.paramsfrom/props, andsyncWithServerDefaults()returned early on empty params, before it got to the block that appliesui_settingson first load. The function now returns early only if there are no params and noui_settingsto apply, so setting values don't change without a UI config or on later visits.Fixes #28260
Additional information
I added a regression test to the existing
ui-settings-sync.svelte.test.tsthat covers the router case (/propswith empty params plusui_settings) and fails without the fix. Client and unit tests,svelte-check,prettierandeslintpass, but I haven't tried this on a live router with--ui-config-file.Requirements