Repository navigation
Conversation
2 of 3 tasks
Contributor
Author
|
Close this PR. It's already included in #29974 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR lets the HMX matmul run on F16/F32 weights whose row count is not a
multiple of 32, and on F16 activations. Both show up on tensors that only
exist at runtime, so they cannot be padded or repacked ahead of time the way
quantized weights are; they have to be handled inside the kernels. The typical
case is
ggml_conv_2din the Qwen3-VL vision encoder: it passes the im2colresult as src0 (its row count is the number of patches) and the kernel weight
as src1 (F16 for an F16 mmproj).
It also fixed a typo which will cause the second weight chunk in the batched matmul prologue wrong.
Additional information
git clang-formatproduced unexpected results. The code is just manually formatted.Requirements