Repository navigation
cuda : Use byte strides for roll to allow non-contiguous ROLL operations - #29547
Merged
Merged
Conversation
github-actions
Bot
added
ggml
|
Hi @bertaye, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
ggml-gh-bot
Bot
added
the
draft
github-actions
Bot
removed
the
draft
bertaye
marked this pull request as ready for review
September 28, 2026 05:37
JohannesGaessler
approved these changes
Oct 6, 2026
JohannesGaessler
added
the
merge ready
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 8, 2026
…ons (ggml-org#29547) (cherry picked from commit d888016)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR allows cuda backend's roll operation to be performed on non-contiguous tensors by using byte strides.
Additional information
Before, the test-backends-ops ROLL testcase for CUDA backend was skipping permute case; after the fix it passes.
Requirements