vulkan: fuse qwen4exp's SCALE -> SIGMOID -> SCALE -> hc_post chain - #29520
Merged
Merged
Conversation
…nel and stops the reorder pass from splitting it
|
Hi @fxgsell, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
jeffbolznv
approved these changes
Sep 27, 2026
0cc4m
approved these changes
Sep 28, 2026
pierreguillot
pushed a commit
to Ircam-Partiels/llama.cpp
that referenced
this pull request
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is a Vulkan-only fusion that runs qwen4exp's SCALE -> SIGMOID -> SCALE -> hc_post chain as one kernel and stops the reorder pass from splitting it; it gives exact output and +3.8% decode, passes all 18,993 tests.
Overview
qwen4exp (Qwen3.8-Flash-Next) builds each hyper-connection's scatter weights as w = 2*sigmoid(inject/hc): three tiny ops on a 4-element tensor, right before dsv4_hc_post. That happens twice per layer, 96 times per token. On Vulkan, decode is limited by the number of kernel dispatches, not by arithmetic, so those 288 dispatches per token cost real time.
The change, all inside the Vulkan backend:
Checks:
Requirements