Skip to content

common : make string_split<T> throw on invalid values - #29518

Merged
angt merged 1 commit into
ggml-org:masterfrom
angt:common-make-string_split-t-throw-on-invalid-values
Sep 27, 2026
Merged

angt merged 1 commit into
ggml-org:masterfrom
angt:common-make-string_split-t-throw-on-invalid-values

Conversation

@angt

@angt angt commented Sep 27, 2026

Copy link
Copy Markdown
Member

Overview

Before:

$ llama-bench -hf unsloth/Qwen3.5-0.8B-GGUF  -nkvo 1,,0 -p 0
| model                          |       size |     params | backend    | threads |          nkvo |            test |                  t/s |
| ------------------------------ | ---------: | ---------: | ---------- | ------: | ------------: | --------------: | -------------------: |
| qwen35 0.8B Q4_K - Medium      | 497.39 MiB |   752.39 M | CPU        |      16 |             1 |           tg128 |         86.32 ± 0.42 |
| qwen35 0.8B Q4_K - Medium      | 497.39 MiB |   752.39 M | CPU        |      16 |             1 |           tg128 |         86.05 ± 0.09 |
| qwen35 0.8B Q4_K - Medium      | 497.39 MiB |   752.39 M | CPU        |      16 |             0 |           tg128 |         87.10 ± 0.21 |

After:

$ llama-bench -hf unsloth/Qwen3.5-0.8B-GGUF  -nkvo 1,,0 -p 0
error: invalid value: ""
error: invalid parameter for argument: -nkvo
...

Additional information

Requirements

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
@angt
angt requested a review from a team as a code owner September 27, 2026 08:24
@angt
angt merged commit 136887b into ggml-org:master Sep 27, 2026
12 checks passed
pierreguillot pushed a commit to Ircam-Partiels/llama.cpp that referenced this pull request Oct 1, 2026
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants