Repository navigation
opencl: refine a8x bin kernel loading condition - #29503
Merged
ggerganov merged 1 commit intoSep 27, 2026
Merged
Conversation
github-actions
Bot
added
ggml
lhez
marked this pull request as ready for review
September 26, 2026 22:43
max-krasnyansky
approved these changes
Sep 26, 2026
max-krasnyansky
added
the
merge ready
wanghqc
added a commit
to qualcomm/llama.cpp
that referenced
this pull request
Sep 29, 2026
ggml-opencl.cpp: this branch's layout kept, the three upstream OpenCL changes (ggml-org#29401 q5_K bin kernels, ggml-org#29439 q8_0 dp4a bin kernel, ggml-org#29503 bin kernel loading condition) replayed onto it. The q5_K bin layout and the q8_0 dp4a bin GEMM are opt-in here (GGML_OPENCL_Q5_K_BIN=1, GGML_OPENCL_Q8_0_BIN_DP4A=1): by default they would take the spec/MTP verify widths from the cooperative-K and narrow kernels. q5_K bin is limited to 2-D weights, q8_0 bin to N > 16. common/speculative, server-context: this branch's llama_batch implementation kept (tree drafting puts several seq_ids on one token, which common_batch cannot hold); a common_batch overload of common_speculative_process converts for the new callers, the mtmd post-decode callback takes the new embd batch, and ggml-org#28876, ggml-org#29556 and ggml-org#29648 are applied to server-context.
pierreguillot
pushed a commit
to Ircam-Partiels/llama.cpp
that referenced
this pull request
Oct 1, 2026
frostyautumnleaf
pushed a commit
to frostyautumnleaf/llama.cpp
that referenced
this pull request
Oct 5, 2026
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 7, 2026
(cherry picked from commit c9064dd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The conditions for loading some A8x binary kernels are too restrictive and prevent from the kernels being loaded on compatible GPUs other than X2. The kernel lib itself checks GPU model to make proper kernels are returned. This PR refines the condition and allows the lib to make the decision.
Additional information
Requirements