Repository navigation
common : fix HF cache paths on Windows - #29475
Merged
Merged
Conversation
Supersedes ggml-org#29158 Signed-off-by: Adrien Gallouët <angt@huggingface.co>
ServeurpersoCom
approved these changes
Sep 28, 2026
ggerganov
approved these changes
Sep 28, 2026
pierreguillot
pushed a commit
to Ircam-Partiels/llama.cpp
that referenced
this pull request
Oct 1, 2026
Supersedes ggml-org#29158 Signed-off-by: Adrien Gallouët <angt@huggingface.co>
frostyautumnleaf
pushed a commit
to frostyautumnleaf/llama.cpp
that referenced
this pull request
Oct 5, 2026
Supersedes ggml-org#29158 Signed-off-by: Adrien Gallouët <angt@huggingface.co>
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 7, 2026
Supersedes ggml-org#29158 Signed-off-by: Adrien Gallouët <angt@huggingface.co> (cherry picked from commit 6c7a87f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix HF cache paths on Windows
Additional information
We introduce a new
common_get_path_from_envinstead of patchingcommon_get_envto avoid regressions and to return a path directly, avoiding string conversionsSupersedes #29158
Requirements