Skip to content

vulkan: fix argsort kernel selection for Adreno - #29469

Merged
ggerganov merged 1 commit into
masterfrom
0cc4m/vulkan-fix-argsort-kernel-selection
Sep 27, 2026
Merged

ggerganov merged 1 commit into
masterfrom
0cc4m/vulkan-fix-argsort-kernel-selection

Conversation

@0cc4m

@0cc4m 0cc4m commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Overview

Current selection for single dispatch assumed maxComputeWorkGroupInvocations to be at most 1024, Adreno has 2048.

Fixes #29431

Requirements

@0cc4m
0cc4m requested a review from a team as a code owner September 26, 2026 07:27
@github-actions github-actions Bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Sep 26, 2026
@0cc4m 0cc4m added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Sep 26, 2026
@ggerganov
ggerganov merged commit cea7462 into master Sep 27, 2026
16 of 22 checks passed
pierreguillot pushed a commit to Ircam-Partiels/llama.cpp that referenced this pull request Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. Vulkan Issues specific to the Vulkan backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misc. bug: Vulkan ARGSORT ne=[2048,1,1,1] only sorts half of the array on some devices

3 participants