Skip to content

server,common : fix the GCC 12 stringop-overread false positive (again) - #29325

Merged
angt merged 1 commit into
ggml-org:masterfrom
angt:server-common-fix-the-gcc-12-stringop-overread-false-positive-again
Sep 24, 2026
Merged

angt merged 1 commit into
ggml-org:masterfrom
angt:server-common-fix-the-gcc-12-stringop-overread-false-positive-again

Conversation

@angt

@angt angt commented Sep 23, 2026

Copy link
Copy Markdown
Member

Overview

Additional information

With

$ gcc --version
gcc (Ubuntu 12.4.0-5ubuntu1) 12.4.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

I got

      inlined from ‘common_speculative_impl_draft_simple::common_speculative_impl_draft_simple(const common_params_speculative&, uint32_t)’ at /home/angt/llamacpp/fixbuild/common/speculative.cpp:233:13:
  /usr/include/c++/12/bits/stl_algobase.h:434:30: error: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ reading between 5 and 9223372036854775807 bytes from a region of size 4 [-Werror=stringop-overread]
    434 |             __builtin_memmove(__result, __first, sizeof(_Tp) * _Num);
        |             ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Requirements

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
@angt
angt requested review from a team as code owners September 23, 2026 16:55
@angt
angt merged commit 2b70583 into ggml-org:master Sep 24, 2026
12 checks passed
frostyautumnleaf pushed a commit to frostyautumnleaf/llama.cpp that referenced this pull request Oct 5, 2026
…n) (ggml-org#29325)

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants