Repository navigation
jinja: use const for statement::execute and ::visit - #29271
Merged
Merged
Conversation
1 task done
CISC
approved these changes
Sep 22, 2026
ggerganov
reviewed
Sep 22, 2026
| statement_ptr test_expr_nullptr; | ||
|
|
||
| statement_ptr & iter_expr = [&]() -> statement_ptr & { | ||
| const statement_ptr & iter_expr = [&]() -> const statement_ptr & { |
Member
There was a problem hiding this comment.
@ngxson These are causing compile errors.
https://github.com/ggml-org/llama.cpp/actions/runs/35735383808/job/106771169478#step:7:390
LadislavSopko
pushed a commit
to 0ics-srls/llama.cpp
that referenced
this pull request
Oct 5, 2026
frostyautumnleaf
pushed a commit
to frostyautumnleaf/llama.cpp
that referenced
this pull request
Oct 5, 2026
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 7, 2026
(cherry picked from commit 348f853)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added
constforvisit,execute_implandexecuteto guarantee thread-safetyRequirements