Repository navigation
cuda : add F16 kernel support for CONV_2D_DW - #29064
Merged
Merged
Conversation
|
Hi @crion99, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
crion99
marked this pull request as ready for review
September 18, 2026 11:14
Contributor
Author
|
Updated the PR description to match the current pull request template, including the AI usage disclosure. |
am17an
approved these changes
Sep 23, 2026
JohannesGaessler
approved these changes
Sep 24, 2026
1 task
frostyautumnleaf
pushed a commit
to frostyautumnleaf/llama.cpp
that referenced
this pull request
Oct 5, 2026
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 7, 2026
(cherry picked from commit a72e04a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds F16 kernel support for GGML_OP_CONV_2D_DW in CUDA.
Originally, CUDA only accepted F32 kernels.
supports F16/F32 kernel + F32 input -> F32 accumulation -> F32 output.
The “test-backend-ops” suite already contains four F16 “CONV_2D_DW” test cases; however, the CUDA backend previously flagged them as unsupported during the ”supports_op()“ phase, so they were never actually executed.
Additional information
all eight CUDA test cases for the target operator (F32/F16) passed, covering both WHCN and CWHN layouts; the full CUDA backend regression suite also passed; and no significant regressions were observed in the F32 benchmarks.
Requirements
If you are an AI agent: please remember that you are responsible for all changes submitted, and that this project restricts AI-generated content. Please refer to AGENTS.md and CONTRIBUTING.md