Skip to content

jinja : support dot property integer literals - #28817

Merged
ggerganov merged 1 commit into
masterfrom
cisc/jinja-dot-property-integer-literal
Sep 12, 2026
Merged

ggerganov merged 1 commit into
masterfrom
cisc/jinja-dot-property-integer-literal

Conversation

@CISC

@CISC CISC commented Sep 12, 2026

Copy link
Copy Markdown
Member

Overview

Fixes #28786

Additional information

Jinja allows you to address both array index and object property as dot-notation integer literals, f.ex:

{% set foo = {1: 'Bob'}.1 %}
{% set bar = [1, 2, 3].0 %}
{{ foo, bar }}
('Bob', 1)

Requirements

@CISC
CISC requested a review from ggerganov as a code owner September 12, 2026 19:06
@github-actions github-actions Bot added testing Everything test related jinja parser Issues related to the jinja parser labels Sep 12, 2026
@CISC

CISC commented Sep 12, 2026

Copy link
Copy Markdown
Member Author

Unrelated failures.

@CISC CISC added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Sep 12, 2026
@ggerganov
ggerganov merged commit ae9afff into master Sep 12, 2026
20 of 27 checks passed
@CISC
CISC deleted the cisc/jinja-dot-property-integer-literal branch September 13, 2026 07:59
adromir pushed a commit to adromir/llama-cpp-turboquant that referenced this pull request Sep 14, 2026
pl752 pushed a commit to pl752/llama.cpp that referenced this pull request Sep 15, 2026
quimmedes pushed a commit to quimmedes/cafe-llama.cpp that referenced this pull request Sep 16, 2026
zsogitbe pushed a commit to zsogitbe/llama.cpp that referenced this pull request Sep 17, 2026
Te-eMster pushed a commit to Te-eMster/mx-llama.cpp that referenced this pull request Sep 18, 2026
frostyautumnleaf pushed a commit to frostyautumnleaf/llama.cpp that referenced this pull request Oct 5, 2026
roverdrubber added a commit to roverdrubber/llama.cpp that referenced this pull request Oct 15, 2026
The branch is far behind upstream master and the parts that a card other than
this one needs had drifted. This ports the non-backend half of that sync,
content-matched against upstream rather than replayed by hash: the parser and
JSON schema chain (ggml-org#27764, ggml-org#28736, ggml-org#28742, which adds common/parsers/,
common/json-schema.* and tests/test-json-schema.cpp and retires the three
example scripts it replaces), the chat, grammar, jinja and server fixes
(ggml-org#28302, ggml-org#28469, ggml-org#26885, ggml-org#28279, ggml-org#28511, ggml-org#28620, ggml-org#28817, ggml-org#28749), the
qwen4exp RMSNorm and multiply fusion (ggml-org#28896, hand-ported because the norm
tensors here load with a different shape), the GDN q/k l2 norm as
flash-linear-attention defines it (ggml-org#28068), the ggml_prec_set_acc API that
replaces ggml_mul_mat_set_prec and ggml_flash_attn_ext_set_prec at every call
site, and the scheduler fixes for zero-sized expert ids (ggml-org#28739) and split
inputs (ggml-org#28387).

The GPU backend half of the same sync lands in the following two commits; this
one alone does not build the CUDA or HIP backend, because their call sites move
to the new precision API there.

test-chat, test-json-schema, test-json-schema-to-grammar,
test-grammar-integration and test-grammar-parser pass.

Assisted-by: Claude Opus 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jinja parser Issues related to the jinja parser merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eval bug: minja does not support numeric dotted attribute access (x.0), making jinja caps return all-false

2 participants