Repository navigation
models: clean up some dead switch branches in old models - #28669
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
I did write the commit message and PR description myself. The only thing I copied from my robit was the |
CISC
approved these changes
Sep 10, 2026
CISC
left a comment
Member
There was a problem hiding this comment.
You can also remove the moe_every_n_layers ffn block for all but nomic-bert-moe.
Some of these if statements were copypastaed in a former refactor and never cleaned up to remove the cases that could never happen anymore. The only thing that's shared between these relatives anymore is llama_model_bert::graph::graph, so the rest of the code doesn't need the conditionals.
iggy
force-pushed
the
chore/clean-up-dead-branches
branch
from
September 10, 2026 10:38
d8f1ecf to
f32d50d
Compare
Contributor
Author
|
Fixed review feedback. Reran ┌──────────────────────────┬────────────────┬────────────┬───────────┬────────────┐
│ model │ arch │ embeddings │ load log │ type label │
├──────────────────────────┼────────────────┼────────────┼───────────┼────────────┤
│ bge-small-en-v1.5 │ bert │ identical │ - │ - │
├──────────────────────────┼────────────────┼────────────┼───────────┼────────────┤
│ jina-reranker-v1-tiny-en │ jina-bert-v2 │ identical │ - │ - │
├──────────────────────────┼────────────────┼────────────┼───────────┼────────────┤
│ nomic-embed-text-v1.5 │ nomic-bert │ identical │ identical │ 137M │
├──────────────────────────┼────────────────┼────────────┼───────────┼────────────┤
│ nomic-embed-text-v2-moe │ nomic-bert-moe │ identical │ identical │ 475M │
├──────────────────────────┼────────────────┼────────────┼───────────┼────────────┤
│ jina-embeddings-v3 │ jina-bert-v3 │ identical │ identical │ 558M │
└──────────────────────────┴────────────────┴────────────┴───────────┴────────────┘ |
CISC
approved these changes
Sep 10, 2026
frostyautumnleaf
pushed a commit
to frostyautumnleaf/llama.cpp
that referenced
this pull request
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Some of these if statements were copypastaed in a former refactor and never cleaned up to remove the cases that could never happen anymore. The only thing that's shared between these relatives anymore is llama_model_bert::graph::graph, so the rest of the code doesn't need the conditionals.
Additional information
I was looking into something unrelated and stumbled on this bit of dead code
Requirements