Repository navigation
ui : shared model display primitives - #28408
Merged
allozaur merged 0 commit intoSep 29, 2026
Merged
Conversation
This was referenced Sep 4, 2026
allozaur
commented
Sep 4, 2026
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 4, 2026 22:49
2e41141 to
b29e9a1
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 4, 2026 23:31
b29e9a1 to
945d63b
Compare
allozaur
marked this pull request as ready for review
September 4, 2026 23:36
allozaur
requested review from
ServeurpersoCom and
ggerganov
and
a lite review from Copilot
September 4, 2026 23:36
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Multiple newly added “shared primitives” are currently not referenced anywhere (dead code / missing integration), and some added documentation claims usage that is not present in the current tree.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Extracts and centralizes UI primitives for displaying model metadata (capability/modality icons, destructive download confirmation, and discover UI building blocks) while expanding ModelId to render additional badges and accept thinking/tool-use support as explicit props.
Changes:
- Updated
ModelIdto use a sharedModelCapabilityIconscomponent and added support for context-length and size-range badges. - Added a new destructive download confirmation enum and dialog component.
- Added discover UI primitives (org avatar component and thin download progress bar) and a dark-mode avatar inversion allowlist.
File summaries
| File | Description |
|---|---|
| tools/ui/src/lib/utils/formatters.ts | Adjusts parameter formatting for billions to render as whole numbers. |
| tools/ui/src/lib/enums/model.enums.ts | Adds ModelDownloadConfirmAction for destructive download confirmations. |
| tools/ui/src/lib/enums/index.ts | Re-exports the new download confirmation action enum. |
| tools/ui/src/lib/constants/ui.constants.ts | Adds DARK_INVERT_AVATAR_ORGS allowlist for dark-mode inversion. |
| tools/ui/src/lib/components/app/models/ModelsSelectorOption.svelte | Switches ModelId usage to pass thinking/tool-use support explicitly. |
| tools/ui/src/lib/components/app/models/ModelId.svelte | Refactors model display layout and integrates shared capability icons + new badges. |
| tools/ui/src/lib/components/app/models/ModelCapabilityIcons.svelte | Introduces shared canonical capability/modality icon cluster with tooltips. |
| tools/ui/src/lib/components/app/models/index.ts | Exports ModelCapabilityIcons and documents intended use. |
| tools/ui/src/lib/components/app/models/discover/ModelsDiscoverAvatar.svelte | Adds discover org avatar component with dark-mode inversion + monogram fallback. |
| tools/ui/src/lib/components/app/models/discover/DownloadProgressBar.svelte | Adds a thin progress bar component for downloads. |
| tools/ui/src/lib/components/app/dialogs/index.ts | Exports DialogConfirmDownload with usage documentation. |
| tools/ui/src/lib/components/app/dialogs/DialogConfirmDownload.svelte | Adds shared destructive confirmation dialog for cancel/delete download actions. |
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 5, 2026 00:52
945d63b to
410052b
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 6, 2026 16:34
410052b to
6a350e3
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 7, 2026 06:12
6a350e3 to
9922795
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 7, 2026 07:00
9922795 to
c85d0d8
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
2 times, most recently
from
September 7, 2026 07:12
a67d25d to
9c4d155
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 7, 2026 08:31
ae6ab5e to
1b04d3c
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 7, 2026 14:21
1b04d3c to
81ef2a3
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 7, 2026 19:00
81ef2a3 to
55e3e5d
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 7, 2026 23:16
55e3e5d to
ca5c3be
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
2 times, most recently
from
September 16, 2026 11:14
5cbc9a1 to
f8ddd56
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 16, 2026 11:56
f8ddd56 to
3712caa
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 28, 2026 10:15
27a11a0 to
516afbb
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 28, 2026 14:34
516afbb to
3592cad
Compare
allozaur
removed this pull request from stack #28420
September 28, 2026 14:39
allozaur
added this pull request to stack #29589
September 28, 2026 14:47
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 28, 2026 14:48
3592cad to
31220d5
Compare
allozaur
removed this pull request from stack #29589
September 28, 2026 15:21
allozaur
added this pull request to stack #29592
September 28, 2026 15:22
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 29, 2026 07:40
31220d5 to
998f07c
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 29, 2026 10:05
998f07c to
f9ee70a
Compare
allozaur
force-pushed
the
allozaur/ui/shared-model-display
branch
from
September 29, 2026 10:27
f9ee70a to
9731a96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Extracts shared model display primitives:
ModelCapabilityIcons(canonical Tools, Reasoning, Vision, Video, Audio order) out ofModelId,DialogConfirmDownloadfor destructive download actions (one instance per surface, driven byDownloadConfirmAction), the discover org avatar with dark-mode inversion, and the thin download progress bar.ModelIdnow takes thinking/tool-use support directly.Requirements
pi:zai-org/GLM-5.3+llama-ui:unsloth/Qwen3.8-Flash-Next