Skip to content

ui : shared model display primitives - #28408

Merged
allozaur merged 0 commit into
allozaur/ui/markdown-allow-htmlfrom
allozaur/ui/shared-model-display
Sep 29, 2026
Merged

allozaur merged 0 commit into
allozaur/ui/markdown-allow-htmlfrom
allozaur/ui/shared-model-display

Conversation

@allozaur

@allozaur allozaur commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Extracts shared model display primitives: ModelCapabilityIcons (canonical Tools, Reasoning, Vision, Video, Audio order) out of ModelId, DialogConfirmDownload for destructive download actions (one instance per surface, driven by DownloadConfirmAction), the discover org avatar with dark-mode inversion, and the thin download progress bar. ModelId now takes thinking/tool-use support directly.

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: YES, pi:zai-org/GLM-5.3 + llama-ui:unsloth/Qwen3.8-Flash-Next

Comment thread tools/ui/src/lib/components/app/models/discover/DownloadProgressBar.svelte Outdated
Comment thread tools/ui/src/lib/components/app/models/ModelCapabilityIcons.svelte Outdated
Comment thread tools/ui/src/lib/enums/model.enums.ts Outdated
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from 2e41141 to b29e9a1 Compare September 4, 2026 22:49
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from b29e9a1 to 945d63b Compare September 4, 2026 23:31
@allozaur
allozaur marked this pull request as ready for review September 4, 2026 23:36
@allozaur
allozaur requested a review from a team as a code owner September 4, 2026 23:36
@allozaur
allozaur requested review from ServeurpersoCom and ggerganov and a lite review from Copilot September 4, 2026 23:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Multiple newly added “shared primitives” are currently not referenced anywhere (dead code / missing integration), and some added documentation claims usage that is not present in the current tree.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Extracts and centralizes UI primitives for displaying model metadata (capability/modality icons, destructive download confirmation, and discover UI building blocks) while expanding ModelId to render additional badges and accept thinking/tool-use support as explicit props.

Changes:

  • Updated ModelId to use a shared ModelCapabilityIcons component and added support for context-length and size-range badges.
  • Added a new destructive download confirmation enum and dialog component.
  • Added discover UI primitives (org avatar component and thin download progress bar) and a dark-mode avatar inversion allowlist.
File summaries
File Description
tools/ui/src/lib/utils/formatters.ts Adjusts parameter formatting for billions to render as whole numbers.
tools/ui/src/lib/enums/model.enums.ts Adds ModelDownloadConfirmAction for destructive download confirmations.
tools/ui/src/lib/enums/index.ts Re-exports the new download confirmation action enum.
tools/ui/src/lib/constants/ui.constants.ts Adds DARK_INVERT_AVATAR_ORGS allowlist for dark-mode inversion.
tools/ui/src/lib/components/app/models/ModelsSelectorOption.svelte Switches ModelId usage to pass thinking/tool-use support explicitly.
tools/ui/src/lib/components/app/models/ModelId.svelte Refactors model display layout and integrates shared capability icons + new badges.
tools/ui/src/lib/components/app/models/ModelCapabilityIcons.svelte Introduces shared canonical capability/modality icon cluster with tooltips.
tools/ui/src/lib/components/app/models/index.ts Exports ModelCapabilityIcons and documents intended use.
tools/ui/src/lib/components/app/models/discover/ModelsDiscoverAvatar.svelte Adds discover org avatar component with dark-mode inversion + monogram fallback.
tools/ui/src/lib/components/app/models/discover/DownloadProgressBar.svelte Adds a thin progress bar component for downloads.
tools/ui/src/lib/components/app/dialogs/index.ts Exports DialogConfirmDownload with usage documentation.
tools/ui/src/lib/components/app/dialogs/DialogConfirmDownload.svelte Adds shared destructive confirmation dialog for cancel/delete download actions.
Review details
  • Files reviewed: 12/12 changed files
  • Comments generated: 5
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tools/ui/src/lib/components/app/dialogs/index.ts
Comment thread tools/ui/src/lib/components/app/models/ModelCapabilityIcons.svelte
Comment thread tools/ui/src/lib/components/app/models/index.ts
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from 945d63b to 410052b Compare September 5, 2026 00:52
@allozaur
allozaur requested review from a team as code owners September 6, 2026 16:34
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from 410052b to 6a350e3 Compare September 6, 2026 16:34
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from 6a350e3 to 9922795 Compare September 7, 2026 06:12
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from 9922795 to c85d0d8 Compare September 7, 2026 07:00
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch 2 times, most recently from a67d25d to 9c4d155 Compare September 7, 2026 07:12
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from ae6ab5e to 1b04d3c Compare September 7, 2026 08:31
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from 1b04d3c to 81ef2a3 Compare September 7, 2026 14:21
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from 81ef2a3 to 55e3e5d Compare September 7, 2026 19:00
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from 55e3e5d to ca5c3be Compare September 7, 2026 23:16
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch 2 times, most recently from 5cbc9a1 to f8ddd56 Compare September 16, 2026 11:14
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from f8ddd56 to 3712caa Compare September 16, 2026 11:56
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from 27a11a0 to 516afbb Compare September 28, 2026 10:15
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from 516afbb to 3592cad Compare September 28, 2026 14:34
@allozaur
allozaur removed this pull request from stack #28420 September 28, 2026 14:39
@allozaur
allozaur added this pull request to stack #29589 September 28, 2026 14:47
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from 3592cad to 31220d5 Compare September 28, 2026 14:48
@allozaur
allozaur removed this pull request from stack #29589 September 28, 2026 15:21
@allozaur
allozaur added this pull request to stack #29592 September 28, 2026 15:22
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from 31220d5 to 998f07c Compare September 29, 2026 07:40
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from 998f07c to f9ee70a Compare September 29, 2026 10:05
@allozaur
allozaur merged commit 9731a96 into master Sep 29, 2026
@allozaur
allozaur force-pushed the allozaur/ui/shared-model-display branch from f9ee70a to 9731a96 Compare September 29, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants