Repository navigation
Conversation
This allows consumers to rely on the context not being mutated while inside another context, which is useful for ensuring thread-safety and correctness.
Contributor
Author
|
Ping @ngxson? |
ggerganov
approved these changes
Sep 28, 2026
ngxson
reviewed
Sep 29, 2026
Comment on lines
417
to
+418
| // can be utilized in various ways, for example by sharing results or llama_memory between 2 contexts | ||
| struct llama_context * ctx_other; | ||
| const struct llama_context * ctx_other; |
Collaborator
There was a problem hiding this comment.
I'm not the code owner of this, so not quite sure. But judging by the code comment above, this should not be const. For example, if llama_memory is shared, one context can edit the memory other another. While it's not implemented for now, it could be in the future, idk
Member
There was a problem hiding this comment.
Makes sense. Let's keep it non-const.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This allows consumers to rely on the
llama_contextnot being mutated while inside anotherllama_context, which is useful for ensuring thread-safety and correctness.CC @ngxson, dunno who else it'd make sense to ping about this?
Additional information
Similar to #28307.
Would be useful in utilityai/llama-cpp-rs#1122.
Requirements