tests: Harmonize header use - #25616
Merged
Merged
Conversation
As with all other tests. This is to ensure that the build uses shipped headers over possibly system-installed ones.
Collaborator
Author
|
@ggerganov, I thought a fresh approach might be simpler/clearer than #25179, where I took a few wrong detours. |
ggerganov
approved these changes
Jul 13, 2026
ggerganov
added
the
merge ready
ggerganov
marked this pull request as ready for review
July 13, 2026 09:51
RehanQasim-dev
pushed a commit
to aifoundry-org/llama.cpp
that referenced
this pull request
Jul 23, 2026
* tests: Harmonize the use of private ggml includes * tests: In test-backend-ops, use quoted includes As with all other tests. This is to ensure that the build uses shipped headers over possibly system-installed ones.
RehanQasim-dev
pushed a commit
to aifoundry-org/llama.cpp
that referenced
this pull request
Jul 23, 2026
* tests: Harmonize the use of private ggml includes * tests: In test-backend-ops, use quoted includes As with all other tests. This is to ensure that the build uses shipped headers over possibly system-installed ones.
satindergrewal
pushed a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 12, 2026
* tests: Harmonize the use of private ggml includes * tests: In test-backend-ops, use quoted includes As with all other tests. This is to ensure that the build uses shipped headers over possibly system-installed ones.
zbrad
pushed a commit
to zbrad/llama.cpp
that referenced
this pull request
Sep 10, 2026
* tests: Harmonize the use of private ggml includes * tests: In test-backend-ops, use quoted includes As with all other tests. This is to ensure that the build uses shipped headers over possibly system-installed ones.
pl752
pushed a commit
to pl752/llama.cpp
that referenced
this pull request
Sep 15, 2026
* tests: Harmonize the use of private ggml includes * tests: In test-backend-ops, use quoted includes As with all other tests. This is to ensure that the build uses shipped headers over possibly system-installed ones.
frostyautumnleaf
pushed a commit
to frostyautumnleaf/llama.cpp
that referenced
this pull request
Oct 5, 2026
* tests: Harmonize the use of private ggml includes * tests: In test-backend-ops, use quoted includes As with all other tests. This is to ensure that the build uses shipped headers over possibly system-installed ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This switches two outliers in tests/ to use quoted-includes (as all the other tests do), rather than bracketed-includes, to ensure the tests are always built against the embedded ggml even in the presence of a system ggml.
The two tests that need private headers are guarded by
NOT LLAMA_USE_SYSTEM_GGML, which lacks them.target_include_directoriesis dropped for test-export-graph-ops because it only uses public headers after all.Additional information
This supersedes #25179.
Requirements