Skip to content

vulkan: add POOL_1D op - #25431

Merged
0cc4m merged 5 commits into
ggml-org:masterfrom
AnandPatil1:fix-issue-14909-pool1d-vulkan
Jul 31, 2026
Merged

vulkan: add POOL_1D op#25431
0cc4m merged 5 commits into
ggml-org:masterfrom
AnandPatil1:fix-issue-14909-pool1d-vulkan

Conversation

@AnandPatil1

@AnandPatil1 AnandPatil1 commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

Add the POOL_1D operation for the Vulkan backend.

Additional information

Part of #14909

Tested on Intel(R) Graphics:

  POOL_1D(pool_type=avg,type_input=f32,ne_input=[10,3,2,1],k0=1,s0=1,p0=0): OK
  POOL_1D(pool_type=avg,type_input=f32,ne_input=[11,1,3,2],k0=1,s0=1,p0=0): OK
  ...  
  POOL_1D(pool_type=max,type_input=f32,ne_input=[128,2,1,3],k0=3,s0=3,p0=3): OK
  216/216 tests passed
  Backend Vulkan0: OK
Backend 2/2: CPU
  Skipping CPU backend
2/2 backends passed
OK

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: YES, I used AI to understand the codebase and to help debug issues I ran into (i.e. missing tensor dimension indices and an error in avg pool scale calculation). I reviewed and tested every change.

@AnandPatil1
AnandPatil1 requested a review from a team as a code owner July 8, 2026 04:14
@github-actions github-actions Bot added documentation Improvements or additions to documentation Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Jul 8, 2026
jeffbolznv
jeffbolznv reviewed Jul 8, 2026
View reviewed changes
Comment thread ggml/src/ggml-vulkan/vulkan-shaders/pool1d.comp Outdated
Comment thread ggml/src/ggml-vulkan/vulkan-shaders/pool1d.comp
@AnandPatil1
vulkan : add pool1d push constants and pipeline field
73716d3 
Declared data structures needed for POOL1D OP, which are the vk_op_pool1d_push_constants struct and pipeline_pool1d_f32 field.
@AnandPatil1
vulkan : add pool1d compute shader
e2dc7ab 
Added pool1d.comp for Vulkan backend mirroring the existing pool2d shader.
@AnandPatil1
vulkan : add full GGML_OP_POOL_1D support
20eceb3 
Added pipeline creation and op dispatch for 1D pooling in the Vulkan backend.
@AnandPatil1
vulkan : fix pool1d shader logic
a67db36 
Registered pool1d_f32 in vulkan-shaders-gen.cpp and fixed tensor dimension indices and avg pool scale.
@AnandPatil1
vulkan : fix pool1d end boundary crash and expand test coverage
cd428e5 
Fixed an issue where the shader crashed when the end boundary was negative when k0 < p0. Also, added more test cases related to this fix.
@AnandPatil1
AnandPatil1 force-pushed the fix-issue-14909-pool1d-vulkan branch from e181da4 to cd428e5 Compare July 29, 2026 04:28
@AnandPatil1
AnandPatil1 requested a review from ggerganov as a code owner July 29, 2026 04:28
@github-actions github-actions Bot added the testing Everything test related label Jul 29, 2026
@0cc4m
0cc4m merged commit 876a432 into ggml-org:master Jul 31, 2026
21 of 28 checks passed
huaxel pushed a commit to huaxel/CachyLLama that referenced this pull request Aug 2, 2026
@AnandPatil1 @huaxel
vulkan: add POOL_1D op (ggml-org#25431)
73ae970 
* vulkan : add pool1d push constants and pipeline field

Declared data structures needed for POOL1D OP, which are the vk_op_pool1d_push_constants struct and pipeline_pool1d_f32 field.

* vulkan : add pool1d compute shader

Added pool1d.comp for Vulkan backend mirroring the existing pool2d shader.

* vulkan : add full GGML_OP_POOL_1D support

Added pipeline creation and op dispatch for 1D pooling in the Vulkan backend.

* vulkan : fix pool1d shader logic

Registered pool1d_f32 in vulkan-shaders-gen.cpp and fixed tensor dimension indices and avg pool scale.

* vulkan : fix pool1d end boundary crash and expand test coverage

Fixed an issue where the shader crashed when the end boundary was negative when k0 < p0. Also, added more test cases related to this fix.
@mstkyvz mstkyvz mentioned this pull request Aug 11, 2026
Open
satindergrewal pushed a commit to satindergrewal/llama.cpp that referenced this pull request Aug 12, 2026
@AnandPatil1
vulkan: add POOL_1D op (ggml-org#25431)
2a0f48e 
* vulkan : add pool1d push constants and pipeline field

Declared data structures needed for POOL1D OP, which are the vk_op_pool1d_push_constants struct and pipeline_pool1d_f32 field.

* vulkan : add pool1d compute shader

Added pool1d.comp for Vulkan backend mirroring the existing pool2d shader.

* vulkan : add full GGML_OP_POOL_1D support

Added pipeline creation and op dispatch for 1D pooling in the Vulkan backend.

* vulkan : fix pool1d shader logic

Registered pool1d_f32 in vulkan-shaders-gen.cpp and fixed tensor dimension indices and avg pool scale.

* vulkan : fix pool1d end boundary crash and expand test coverage

Fixed an issue where the shader crashed when the end boundary was negative when k0 < p0. Also, added more test cases related to this fix.
thecodacus pushed a commit to thecodacus/llama.cpp that referenced this pull request Sep 7, 2026
@AnandPatil1
vulkan: add POOL_1D op (ggml-org#25431)
83a5c82 
* vulkan : add pool1d push constants and pipeline field

Declared data structures needed for POOL1D OP, which are the vk_op_pool1d_push_constants struct and pipeline_pool1d_f32 field.

* vulkan : add pool1d compute shader

Added pool1d.comp for Vulkan backend mirroring the existing pool2d shader.

* vulkan : add full GGML_OP_POOL_1D support

Added pipeline creation and op dispatch for 1D pooling in the Vulkan backend.

* vulkan : fix pool1d shader logic

Registered pool1d_f32 in vulkan-shaders-gen.cpp and fixed tensor dimension indices and avg pool scale.

* vulkan : fix pool1d end boundary crash and expand test coverage

Fixed an issue where the shader crashed when the end boundary was negative when k0 < p0. Also, added more test cases related to this fix.
zbrad pushed a commit to zbrad/llama.cpp that referenced this pull request Sep 10, 2026
@AnandPatil1
vulkan: add POOL_1D op (ggml-org#25431)
a679c90 
* vulkan : add pool1d push constants and pipeline field

Declared data structures needed for POOL1D OP, which are the vk_op_pool1d_push_constants struct and pipeline_pool1d_f32 field.

* vulkan : add pool1d compute shader

Added pool1d.comp for Vulkan backend mirroring the existing pool2d shader.

* vulkan : add full GGML_OP_POOL_1D support

Added pipeline creation and op dispatch for 1D pooling in the Vulkan backend.

* vulkan : fix pool1d shader logic

Registered pool1d_f32 in vulkan-shaders-gen.cpp and fixed tensor dimension indices and avg pool scale.

* vulkan : fix pool1d end boundary crash and expand test coverage

Fixed an issue where the shader crashed when the end boundary was negative when k0 < p0. Also, added more test cases related to this fix.
pl752 pushed a commit to pl752/llama.cpp that referenced this pull request Sep 15, 2026
@AnandPatil1 @pl752
vulkan: add POOL_1D op (ggml-org#25431)
2f84dbf 
* vulkan : add pool1d push constants and pipeline field

Declared data structures needed for POOL1D OP, which are the vk_op_pool1d_push_constants struct and pipeline_pool1d_f32 field.

* vulkan : add pool1d compute shader

Added pool1d.comp for Vulkan backend mirroring the existing pool2d shader.

* vulkan : add full GGML_OP_POOL_1D support

Added pipeline creation and op dispatch for 1D pooling in the Vulkan backend.

* vulkan : fix pool1d shader logic

Registered pool1d_f32 in vulkan-shaders-gen.cpp and fixed tensor dimension indices and avg pool scale.

* vulkan : fix pool1d end boundary crash and expand test coverage

Fixed an issue where the shader crashed when the end boundary was negative when k0 < p0. Also, added more test cases related to this fix.
frostyautumnleaf pushed a commit to frostyautumnleaf/llama.cpp that referenced this pull request Oct 5, 2026
@AnandPatil1
vulkan: add POOL_1D op (ggml-org#25431)
dae9dee 
* vulkan : add pool1d push constants and pipeline field

Declared data structures needed for POOL1D OP, which are the vk_op_pool1d_push_constants struct and pipeline_pool1d_f32 field.

* vulkan : add pool1d compute shader

Added pool1d.comp for Vulkan backend mirroring the existing pool2d shader.

* vulkan : add full GGML_OP_POOL_1D support

Added pipeline creation and op dispatch for 1D pooling in the Vulkan backend.

* vulkan : fix pool1d shader logic

Registered pool1d_f32 in vulkan-shaders-gen.cpp and fixed tensor dimension indices and avg pool scale.

* vulkan : fix pool1d end boundary crash and expand test coverage

Fixed an issue where the shader crashed when the end boundary was negative when k0 < p0. Also, added more test cases related to this fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffbolznv jeffbolznv jeffbolznv approved these changes
@0cc4m 0cc4m 0cc4m approved these changes
@ggerganov ggerganov Awaiting requested review from ggerganov ggerganov is a code owner

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ggml changes relating to the ggml tensor library for machine learning testing Everything test related Vulkan Issues specific to the Vulkan backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AnandPatil1 @jeffbolznv @0cc4m