Skip to content

metal: add GATED_LINEAR_ATTN support - #21859

Closed
Ra5hidIslam wants to merge 1 commit into
ggml-org:masterfrom
Ra5hidIslam:metal-add-gated_linear_attn
Closed

Ra5hidIslam wants to merge 1 commit into
ggml-org:masterfrom
Ra5hidIslam:metal-add-gated_linear_attn

Conversation

@Ra5hidIslam

Copy link
Copy Markdown
Contributor

Overview

Added Gated Linear Attention Op for Metal

Additional information

Passed all the tests, no performance test was there so couldn't test the performance.

Related to #14909

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: Yes, in understanding the code, all code and logic has been written by me.

@Ra5hidIslam
Ra5hidIslam requested a review from a team as a code owner April 13, 2026 15:48
@github-actions github-actions Bot added ggml changes relating to the ggml tensor library for machine learning Apple Metal https://en.wikipedia.org/wiki/Metal_(API) labels Apr 13, 2026
@TheTom

TheTom commented Apr 20, 2026

Copy link
Copy Markdown

Hey @Ra5hidIslam, nice work on this! Just wanted to flag that I have an existing PR for the same op over at #21452, filed April 5. It covers head_size 64 and 128, includes test-backend-ops updates, and regenerates the docs. Might be worth consolidating so we're not duplicating effort. Happy to collaborate if you want to combine forces!

@Ra5hidIslam

Copy link
Copy Markdown
Contributor Author

Hey @Ra5hidIslam, nice work on this! Just wanted to flag that I have an existing PR for the same op over at #21452, filed April 5. It covers head_size 64 and 128, includes test-backend-ops updates, and regenerates the docs. Might be worth consolidating so we're not duplicating effort. Happy to collaborate if you want to combine forces!

Thanks for the heads up, didn't see #21452 when I started. Your PR is further along (both head sizes + tests + docs), so it makes sense to consolidate there. Happy to review it and contribute anything useful from my implementation. Closing this one.

@Ra5hidIslam

Copy link
Copy Markdown
Contributor Author

Closing this one, as there is a prior PR with #21452 which is doing the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Apple Metal https://en.wikipedia.org/wiki/Metal_(API) ggml changes relating to the ggml tensor library for machine learning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants