Repository navigation
Conversation
Author
|
Fixed an unintended change in the PR. |
ngxson
reviewed
Oct 17, 2025
Author
|
Hello, are there any remaining tasks to be done with the merge? Is there anything I can help with? |
kuguma
force-pushed
the
fix-mtmd-filepath-encoding
branch
from
January 16, 2026 08:31
a2bc45b to
cb9588a
Compare
Collaborator
|
superseded by #24779 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed path handling in the mtmd feature on Windows to correctly convert and process non-ASCII file paths.
Additionally, fixed a missing console initialization in mtmd-cli.
Issues Resolved
Failed to load .mmproj files with non-ASCII file paths
Failed to load image files with non-ASCII file paths
Incorrect path parsing in mtmd-cli when using
/image <filepath>with non-ASCII charactersComparison of behavior
Windows 11 Pro 24H2
b6756
This PR
Notes
The general argument-handling logic in llama.cpp also has issues with non-ASCII paths.
Since the impact area is broad, I will submit a separate PR to address this.