Repository navigation
mtmd : move helpers to dedicated file - #13442
Merged
Merged
Conversation
ggerganov
approved these changes
May 11, 2025
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* mtmd : move helpers to dedicated file * fix windows build * rm redundant include
my-other-github-account
pushed a commit
to my-other-github-account/llama.cpp
that referenced
this pull request
May 15, 2026
* mtmd : move helpers to dedicated file * fix windows build * rm redundant include
AlexiAlp
pushed a commit
to minghaop/llama.cpp
that referenced
this pull request
Jun 2, 2026
* mtmd : move helpers to dedicated file * fix windows build * rm redundant include
AlexiAlp
pushed a commit
to minghaop/llama.cpp
that referenced
this pull request
Jun 2, 2026
* mtmd : move helpers to dedicated file * fix windows build * rm redundant include
fukuro-kun
pushed a commit
to fukuro-kun/fukuro-llama-cpp-turboquant
that referenced
this pull request
Jul 5, 2026
* mtmd : move helpers to dedicated file * fix windows build * rm redundant include
zommiommy
pushed a commit
to zommiommy/llama.cpp
that referenced
this pull request
Aug 18, 2026
* mtmd : move helpers to dedicated file * fix windows build * rm redundant include
frostyautumnleaf
pushed a commit
to frostyautumnleaf/llama.cpp
that referenced
this pull request
Oct 5, 2026
* mtmd : move helpers to dedicated file * fix windows build * rm redundant include
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref discussion: #13366 (comment) (cc @mattjcly)
These helper functions are suppose to be the equivalent of
common.cpp, so by moving it to a dedicated file, we can prevent accidentally using internal mtmd API in the helper.2 exceptions of this rule are:
mtmd_helper_bitmap_init_from_filemtmd_helper_bitmap_init_from_bufThe reason is because these APIs use internal struct from
clip.cpp. Fromlibmtmdperspective, we never want to exposeclip_contextto the outside world. However, the problem with these 2 APIs can be resolved by simply movestb_imagetomtmh_helper.cpp. But since this is a breaking change toclip, I'll do it later on.