cmake : enable curl by default by ngxson · Pull Request #12761 · ggml-org/llama.cpp

ngxson · 2025-04-04T21:56:05Z

When curl was first added to the project, we decided to leave it disabled by default because there was no guarantee that the target system has libcurl installed.

But lot of things changed since then, curl now become part of the overall UX of llama.cpp examples. Most of the pre-built version (including own docker images and release binary) have it enabled, so I think it's now a good time to turn it on by default.

ngxson · 2025-04-04T22:21:32Z

I have no idea how to make the build-linux-cross to work, so I'll disable curl for those (unless someone knows how to fix it)

For windows build, I'll have a look to see how we can setup libcurl without copying the same code everywhere.

ngxson · 2025-04-05T12:20:47Z

+# TODO: avoid copying this code block from common/CMakeLists.txt
+set(LLAMA_RUN_EXTRA_LIBS "")
+if (LLAMA_CURL)
+    find_package(CURL REQUIRED)
+    target_compile_definitions(${TARGET} PUBLIC LLAMA_USE_CURL)
+    include_directories(${CURL_INCLUDE_DIRS})
+    find_library(CURL_LIBRARY curl REQUIRED)
+    set(LLAMA_RUN_EXTRA_LIBS ${LLAMA_RUN_EXTRA_LIBS} ${CURL_LIBRARY})
+endif ()


@ericcurtin FYI, seems like llama-run was not linked against curl on windows, which will result in compilation error (cannot find curl/curl.h header). I made this quick fix which should work for now.

By default, only libcommon is linked against curl.

Thanks @ngxson FWIW we are moving away from using llama-run in RamaLama, I wrote a kinda client server thing that automatically terminates both processes on completion instead (the experience is similar to llama-run but better). I was starting to dislike the duplication of efforts in llama-run and llama-server. So I want to try and consolidate on llama-server.

It's a neat tool to test llama-server with all kinds of models, I'm almost ready to push the full version of it to main in RamaLama.

I'll still be happy to look at PRs around llama-run, etc. but it probably won't be actively used in RamaLama anymore at least.

ngxson · 2025-04-05T12:41:40Z

@ggerganov This should be ready for review. Btw, I think it will be more convenient to statically link libcurl on windows as curl is not installed at system level. I can give a try in a follow-up PR.

ggerganov · 2025-04-06T08:45:34Z

 # utils, programs, examples and tests
 #

+if (NOT LLAMA_BUILD_EXAMPLES OR NOT LLAMA_BUILD_COMMON)


Suggested change

if (NOT LLAMA_BUILD_EXAMPLES OR NOT LLAMA_BUILD_COMMON)

if (NOT LLAMA_BUILD_EXAMPLES AND NOT LLAMA_BUILD_COMMON)

Also add a CMake log message when this branch is executed.

On second thought, I think this condition should be just if NOT LLAMA_BUILD_COMMON, because we cannot build (most of the) examples without libcommon

Fixed in 533e0dc

ggerganov · 2025-04-06T08:51:36Z

Would the Windows binaries in the releases now have curl support after this change?

slaren · 2025-04-06T15:46:09Z

                  gcc-14-riscv64-linux-gnu \
-                  g++-14-riscv64-linux-gnu
+                  g++-14-riscv64-linux-gnu \
+                  libcurl4-openssl-dev


Does this work?

Suggested change

libcurl4-openssl-dev

libcurl4-openssl-dev:riscv64

Thanks, it works. I tested on my fork: https://github.com/ngxson/llama.cpp/actions/runs/14295363304/job/40061820312

ngxson · 2025-04-06T18:20:39Z

Would the Windows binaries in the releases now have curl support after this change?

Yeah that's a good question, I thought that we always copy the libcurl-x64.dll to the release artifact, but turns out we don't (we only use libcurl-x64.dll on server CI). For now, I'll add this to the windows release.

…-org#12761)

…) (#12937)

…-org#12761) (ggml-org#12937)

* cmake : enable curl by default * no curl if no examples * fix build * fix build-linux-cross * add windows-setup-curl * fix * shell * fix path * fix windows-latest-cmake* * run: include_directories * LLAMA_RUN_EXTRA_LIBS * sycl: no llama_curl * no test-arg-parser on windows * clarification * try riscv64 / arm64 * windows: include libcurl inside release binary * add msg * fix mac / ios / android build * will this fix xcode? * try clearing the cache * add bunch of licenses * revert clear cache * fix xcode * fix xcode (2) * fix typo

ggml-org/llama.cpp#12761, not noticed until now because older commit of llama.cpp was cached by Android Studio

* cmake : enable curl by default * no curl if no examples * fix build * fix build-linux-cross * add windows-setup-curl * fix * shell * fix path * fix windows-latest-cmake* * run: include_directories * LLAMA_RUN_EXTRA_LIBS * sycl: no llama_curl * no test-arg-parser on windows * clarification * try riscv64 / arm64 * windows: include libcurl inside release binary * add msg * fix mac / ios / android build * will this fix xcode? * try clearing the cache * add bunch of licenses * revert clear cache * fix xcode * fix xcode (2) * fix typo

…-org#12761) (ggml-org#12937)

* cmake : enable curl by default * no curl if no examples * fix build * fix build-linux-cross * add windows-setup-curl * fix * shell * fix path * fix windows-latest-cmake* * run: include_directories * LLAMA_RUN_EXTRA_LIBS * sycl: no llama_curl * no test-arg-parser on windows * clarification * try riscv64 / arm64 * windows: include libcurl inside release binary * add msg * fix mac / ios / android build * will this fix xcode? * try clearing the cache * add bunch of licenses * revert clear cache * fix xcode * fix xcode (2) * fix typo

…-org#12761) (ggml-org#12937)

* cmake : enable curl by default * no curl if no examples * fix build * fix build-linux-cross * add windows-setup-curl * fix * shell * fix path * fix windows-latest-cmake* * run: include_directories * LLAMA_RUN_EXTRA_LIBS * sycl: no llama_curl * no test-arg-parser on windows * clarification * try riscv64 / arm64 * windows: include libcurl inside release binary * add msg * fix mac / ios / android build * will this fix xcode? * try clearing the cache * add bunch of licenses * revert clear cache * fix xcode * fix xcode (2) * fix typo

…-org#12761) (ggml-org#12937)

* cmake : enable curl by default * no curl if no examples * fix build * fix build-linux-cross * add windows-setup-curl * fix * shell * fix path * fix windows-latest-cmake* * run: include_directories * LLAMA_RUN_EXTRA_LIBS * sycl: no llama_curl * no test-arg-parser on windows * clarification * try riscv64 / arm64 * windows: include libcurl inside release binary * add msg * fix mac / ios / android build * will this fix xcode? * try clearing the cache * add bunch of licenses * revert clear cache * fix xcode * fix xcode (2) * fix typo

…-org#12761) (ggml-org#12937)

* cmake : enable curl by default * no curl if no examples * fix build * fix build-linux-cross * add windows-setup-curl * fix * shell * fix path * fix windows-latest-cmake* * run: include_directories * LLAMA_RUN_EXTRA_LIBS * sycl: no llama_curl * no test-arg-parser on windows * clarification * try riscv64 / arm64 * windows: include libcurl inside release binary * add msg * fix mac / ios / android build * will this fix xcode? * try clearing the cache * add bunch of licenses * revert clear cache * fix xcode * fix xcode (2) * fix typo

…-org#12761) (ggml-org#12937)

* cmake : enable curl by default * no curl if no examples * fix build * fix build-linux-cross * add windows-setup-curl * fix * shell * fix path * fix windows-latest-cmake* * run: include_directories * LLAMA_RUN_EXTRA_LIBS * sycl: no llama_curl * no test-arg-parser on windows * clarification * try riscv64 / arm64 * windows: include libcurl inside release binary * add msg * fix mac / ios / android build * will this fix xcode? * try clearing the cache * add bunch of licenses * revert clear cache * fix xcode * fix xcode (2) * fix typo

…-org#12761) (ggml-org#12937)

* cmake : enable curl by default * no curl if no examples * fix build * fix build-linux-cross * add windows-setup-curl * fix * shell * fix path * fix windows-latest-cmake* * run: include_directories * LLAMA_RUN_EXTRA_LIBS * sycl: no llama_curl * no test-arg-parser on windows * clarification * try riscv64 / arm64 * windows: include libcurl inside release binary * add msg * fix mac / ios / android build * will this fix xcode? * try clearing the cache * add bunch of licenses * revert clear cache * fix xcode * fix xcode (2) * fix typo

…-org#12761) (ggml-org#12937)

* cmake : enable curl by default * no curl if no examples * fix build * fix build-linux-cross * add windows-setup-curl * fix * shell * fix path * fix windows-latest-cmake* * run: include_directories * LLAMA_RUN_EXTRA_LIBS * sycl: no llama_curl * no test-arg-parser on windows * clarification * try riscv64 / arm64 * windows: include libcurl inside release binary * add msg * fix mac / ios / android build * will this fix xcode? * try clearing the cache * add bunch of licenses * revert clear cache * fix xcode * fix xcode (2) * fix typo

…-org#12761) (ggml-org#12937)

cmake : enable curl by default

6080f6e

ngxson requested a review from ggerganov April 4, 2025 21:56

github-actions Bot added build Compilation issues examples devops improvements to build systems and github actions server labels Apr 4, 2025

ngxson added 3 commits April 5, 2025 00:03

no curl if no examples

6455796

fix build

2cc893b

fix build-linux-cross

793074c

ngxson added 10 commits April 5, 2025 12:27

add windows-setup-curl

2238e70

fix

707f2b9

shell

79509cc

fix path

21c423e

fix windows-latest-cmake*

9bf42cd

run: include_directories

a8a7ed9

LLAMA_RUN_EXTRA_LIBS

a963705

sycl: no llama_curl

04eddb8

no test-arg-parser on windows

64faafc

clarification

1c1c2c7

github-actions Bot added testing Everything test related SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Apr 5, 2025

ngxson commented Apr 5, 2025

View reviewed changes

ericcurtin approved these changes Apr 5, 2025

View reviewed changes

ggerganov approved these changes Apr 6, 2025

View reviewed changes

ggerganov requested a review from slaren April 6, 2025 08:51

slaren reviewed Apr 6, 2025

View reviewed changes

NeoZhangJianyu added a commit to NeoZhangJianyu/llama.cpp that referenced this pull request Apr 14, 2025

dsiable curl lib check, this action is missed by commit bd3f59f (ggml…

3fa463c

…-org#12761)

NeoZhangJianyu mentioned this pull request Apr 14, 2025

[SYCL]Disable curl lib check in examples/sycl/build.sh #12937

Merged

NeoZhangJianyu added a commit that referenced this pull request Apr 14, 2025

dsiable curl lib check, this action is missed by commit bd3f59f (#12761…

81c7e64

…) (#12937)

colout pushed a commit to colout/llama.cpp that referenced this pull request Apr 21, 2025

dsiable curl lib check, this action is missed by commit bd3f59f (ggml…

87dd778

…-org#12761) (ggml-org#12937)

tobiasvonderheidt added a commit to tobiasvonderheidt/hips that referenced this pull request May 11, 2025

Breaking change in llama.cpp

ebdb808

ggml-org/llama.cpp#12761, not noticed until now because older commit of llama.cpp was cached by Android Studio

ngxson mentioned this pull request Jan 7, 2026

common: use httplib + boringssl by default #18648

Closed

Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026

dsiable curl lib check, this action is missed by commit bd3f59f (ggml…

9d946b8

…-org#12761) (ggml-org#12937)

ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026

dsiable curl lib check, this action is missed by commit fee9570 (ggml…

e280165

…-org#12761) (ggml-org#12937)

my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026

dsiable curl lib check, this action is missed by commit e3f7e43 (ggml…

5712e6f

…-org#12761) (ggml-org#12937)

AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026

dsiable curl lib check, this action is missed by commit a6af7ae (ggml…

419aaad

…-org#12761) (ggml-org#12937)

AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026

dsiable curl lib check, this action is missed by commit f1d2b2a (ggml…

d222f78

…-org#12761) (ggml-org#12937)

fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026

dsiable curl lib check, this action is missed by commit 591c182 (ggml…

6a6b26a

…-org#12761) (ggml-org#12937)

zommiommy pushed a commit to zommiommy/llama.cpp that referenced this pull request Aug 18, 2026

dsiable curl lib check, this action is missed by commit bd3f59f (ggml…

bb6cb18

…-org#12761) (ggml-org#12937)

frostyautumnleaf pushed a commit to frostyautumnleaf/llama.cpp that referenced this pull request Oct 5, 2026

dsiable curl lib check, this action is missed by commit bd3f59f (ggml…

745ab01

…-org#12761) (ggml-org#12937)

Navigation Menu

Repository navigation

cmake : enable curl by default - #12761

cmake : enable curl by default#12761
ngxson merged 25 commits into
ggml-org:masterfrom
ngxson:xsn/curl_on_by_default

ngxson commented Apr 4, 2025 •

edited

Loading

Uh oh!

ngxson commented Apr 4, 2025

Uh oh!

ngxson Apr 5, 2025

Uh oh!

ericcurtin Apr 5, 2025

Uh oh!

ngxson commented Apr 5, 2025

Uh oh!

ggerganov Apr 6, 2025

Uh oh!

ngxson Apr 6, 2025

Uh oh!

ngxson Apr 6, 2025

Uh oh!

ggerganov commented Apr 6, 2025

Uh oh!

slaren Apr 6, 2025

Uh oh!

ngxson Apr 6, 2025

Uh oh!

ngxson commented Apr 6, 2025 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	if (NOT LLAMA_BUILD_EXAMPLES OR NOT LLAMA_BUILD_COMMON)
	if (NOT LLAMA_BUILD_EXAMPLES AND NOT LLAMA_BUILD_COMMON)

Conversation

ngxson commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ngxson commented Apr 4, 2025

Uh oh!

ngxson Apr 5, 2025

Choose a reason for hiding this comment

Uh oh!

ericcurtin Apr 5, 2025

Choose a reason for hiding this comment

Uh oh!

ngxson commented Apr 5, 2025

Uh oh!

ggerganov Apr 6, 2025

Choose a reason for hiding this comment

Uh oh!

ngxson Apr 6, 2025

Choose a reason for hiding this comment

Uh oh!

ngxson Apr 6, 2025

Choose a reason for hiding this comment

Uh oh!

ggerganov commented Apr 6, 2025

Uh oh!

slaren Apr 6, 2025

Choose a reason for hiding this comment

Uh oh!

ngxson Apr 6, 2025

Choose a reason for hiding this comment

Uh oh!

ngxson commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ngxson commented Apr 4, 2025 •

edited

Loading

ngxson commented Apr 6, 2025 •

edited

Loading