Repository navigation
nemotron-3.5-lightning : add model conversion support - #16
Merged
Merged
Conversation
Member
Author
|
Just a note, I think it might be nice to have --keep flag for the conversion script to not remove the downloaded models , or the converted models even if the conversion script succeeds. |
Member
|
Yes, a |
Member
Author
|
I've tried out MT and DFlash which work, but I was not able to get DSpark to work. Trying to load the draft model results in the following error: 0.02.977.124 E llama_model_load: error loading model: check_tensor_dims: tensor 'conf_proj.weight' not found
0.02.977.147 E llama_model_load_from_file_impl: failed to load model I suspect that support for it might not be in llama.cpp yet and the current implementation assumes that there is a confidence projection tensor but this model does not seem to include one and perhaps does not use confidence verification at all. I'll look into this. |
Member
|
Ok, I am also not sure about the status of DSpark for this model. |
danbev
added a commit
that referenced
this pull request
Aug 13, 2026
This commit adds a --keep option which when set will not remove the downloaded models, or the converted models. The motivation for this is that it can be useful to keep the original models and converted models for testing even if the conversion and uploading is successful. Refs: #16 (comment)
danbev
added a commit
that referenced
this pull request
Aug 13, 2026
This commit adds a --keep option which when set will not remove the downloaded models, or the converted models. The motivation for this is that it can be useful to keep the original models and converted models for testing even if the conversion and uploading is successful. Refs: #16 (comment)
This commit adds conversion support for NVIDIA Nemotron 3.5 Lightning. It does not include NVFP4 models, including dflash and dspark. The motivation for not including these conversion is that those checkpoint was designed as W4A16, but the converted GGUF only says that Its weights are NVFP4. On Blackwell, llama.cpp sees NVFP4 weights and will automatically selects its native FP4 path, dynamically converting activations to FP4. That makes the executed operation W4A4 which can affect the accuracy of the draft model and therefor in turn effect the acceptance rate of the target model. The references PR below has more details on a solution to address this issue. Once it has been merged we should be able to convert and publish these models, but for now we are just commenting them out. Refs: ggml-org/llama.cpp#26675
danbev
force-pushed
the
nemotron-3.5-lightning
branch
from
August 14, 2026 05:35
76cfb4b to
80be575
Compare
danbev
marked this pull request as ready for review
August 14, 2026 05:36
ggerganov
reviewed
Aug 14, 2026
ggerganov
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds conversion support for NVIDIA Nemotron 3.5 Lightning.
It does not include NVFP4 models, including dflash and dspark.
The motivation for not including these conversion is that those
checkpoint was designed as W4A16, but the converted GGUF only says that
Its weights are NVFP4. On Blackwell, llama.cpp sees NVFP4 weights and
will automatically selects its native FP4 path, dynamically converting
activations to FP4. That makes the executed operation W4A4 which can
affect the accuracy of the draft model and therefor in turn effect the
acceptance rate of the target model. The references PR below has more
details on a solution to address this issue. Once it has been merged we
should be able to convert and publish these models, but for now we are
just commenting them out.
Refs: ggml-org/llama.cpp#26675
I've build this and uploaded to my HF account:
https://huggingface.co/danbev/NVIDIA-Nemotron-3.5-Lightning-30B-A3B-GGUF/tree/main
I'm creating this as a draft as I want to run some manual test to try out the mtp, dflash, and dspark speculative drafting.