Fix D3D12 Surface Leak#4106
Merged
Merged
Conversation
cwfitzgerald
force-pushed
the
dx12-surface-leak
branch
from
96f82f7 to
fe4c71b
Compare
Elabajaba
approved these changes
Sep 1, 2023
Elabajaba
left a comment
Elabajaba
left a comment
Contributor
There was a problem hiding this comment.
Tested and it works for me on amd+windows11+dx12 and vulkan.
cwfitzgerald
force-pushed
the
dx12-surface-leak
branch
from
fe4c71b to
86cee12
Compare
jimblandy
approved these changes
Sep 1, 2023
jimblandy
left a comment
jimblandy
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Some suggestions and typos:
cwfitzgerald
added
the
PR: needs back-porting
bradwerth
pushed a commit
to bradwerth/wgpu
that referenced
this pull request
Sep 19, 2023
cwfitzgerald
added a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Sep 27, 2023
cwfitzgerald
removed
the
PR: needs back-porting
cwfitzgerald
added a commit
that referenced
this pull request
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Closes #3967
Found #4105
Description
Re-defines the wgpu-hal contract a bit, allowing proper destruction of resources before swap chain resize.