Repository navigation
Develop - #105
Merged
Merged
Develop#105
Conversation
added 9 commits
December 21, 2012 19:09
- Introducing an adaptive enlargement factor; just using TOLERANCE sometimes caused the steps to be too large in the first iteration and produced rootfinder search intervals with inverted bounds.
The shells have to be constructed at the "real" position of the CoM, i.e. the one with applied boundaries and projections. In contrast, the calculations have all to be performed using the CoM as calculated in one of the two structures (structure1). That was not the case and is fixed by this commit. Yet to be cleaned up after testing.
YetAnotherTomek
added a commit
that referenced
this pull request
Jan 16, 2013
Mainly fixes some issue with determining rootfinder boundaries in EDGE_HITS_EDGE cylinder collision and TransitionPair shell construction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly fixes some issue with determining rootfinder boundaries in EDGE_HITS_EDGE cylinder collision and TransitionPair shell construction