fix(oauth): Require redirect_uri parameter when multiple URIs are registered#99004
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
…istered When an OAuth application has multiple redirect URIs registered, the OAuth 2.0 specification (RFC 6749 §3.1.2.3) requires that clients must provide an exact redirect_uri parameter in their authorization request. This change enforces that requirement by returning an invalid_request error if no redirect_uri is provided when multiple URIs are registered for the application. Refs #99002
dcramer
force-pushed
the
oauth-redirect-uri-multiple-match
branch
from
50f5228 to
bda94c5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #99004 +/- ##
==========================================
- Coverage 81.34% 81.23% -0.11%
==========================================
Files 8544 8538 -6
Lines 379244 377152 -2092
Branches 23956 23956
==========================================
- Hits 308485 306372 -2113
- Misses 70393 70414 +21
Partials 366 366 |
leedongwei
approved these changes
Sep 10, 2025
oioki
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an OAuth application has multiple redirect URIs registered, the OAuth 2.0 specification (RFC 6749 §3.1.2.3) requires that clients must provide an exact redirect_uri parameter in their authorization request.
This change enforces that requirement by returning an invalid_request error if no redirect_uri is provided when multiple URIs are registered for the application.
Refs #99002