fix(controlsilo) Don't include internal endpoints in controlsilourls#112166
fix(controlsilo) Don't include internal endpoints in controlsilourls#112166
Conversation
We don't need to include internal only endpoints in the control silo URL mappings. I've added a `internal_control_silo_endpoint` decorator to cover this scenario as we didn't have enough metadata elsewhere.
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| """ | ||
| Apply to endpoints that exist in CONTROL silo that | ||
| should not be included in the frontend URL mapping | ||
| """ |
There was a problem hiding this comment.
Missing __all__ export for new decorator
Low Severity
The new internal_control_silo_endpoint is not added to the __all__ list, unlike its siblings internal_cell_silo_endpoint and internal_all_silo_endpoint which are both included. This inconsistency means it won't be available via wildcard imports and is missing from the module's declared public API.
Additional Locations (1)
2 participants
We don't need to include internal only endpoints in the control silo URL mappings. I've added a
internal_control_silo_endpointdecorator to cover this scenario as we didn't have enough metadata elsewhere.