fix(dashboards): Check query ID before moving out of loading state#106449
Merged
narsaynorath merged 1 commit intoJan 16, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
DominikB2014
approved these changes
Jan 16, 2026
narsaynorath
deleted the
nar/fix/dashboards-check-query-id-before-changing-loading-false
branch
BYK
pushed a commit
that referenced
this pull request
Jan 19, 2026
…106449) Two requests can clobber each other when another request is fired before the previous one finishes. This checks that the current query ID we've generated is currently being processed, ignoring past requests for state changes (i.e. we don't change loading -> `false` if it's not the most current request) Fixes EXP-712
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two requests can clobber each other when another request is fired before the previous one finishes. This checks that the current query ID we've generated is currently being processed, ignoring past requests for state changes (i.e. we don't change loading ->
falseif it's not the most current request)Fixes EXP-712