Skip to content

fix(prompts): Remove redundant organization_id from GET query params #106413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaydgoss merged 5 commits into from
Jan 21, 2026
Merged

fix(prompts): Remove redundant organization_id from GET query params #106413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8d7b0a8
fix(prompts): Remove redundant organization_id from GET query params
dcramer Jan 15, 2026
1a42364
refactor(prompts): Make organization parameter non-nullable
jaydgoss Jan 20, 2026
11fd896
test(prompts): Update test to reflect removed organization_id query p…
jaydgoss Jan 20, 2026
0c46919
fix(prompts): Restore optional chaining in makePromptsCheckQueryKey
jaydgoss Jan 20, 2026
002a930
refactor(prompts): Allow nullable organization in hooks while keeping…
jaydgoss Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions static/app/actionCreators/prompts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,19 @@ type PromptCheckParams = {
* The prompt feature name
*/
feature: string | string[];
organization: OrganizationSummary | null;
organization: OrganizationSummary;
/**
* The numeric project ID as a string
*/
projectId?: string;
};

type PromptCheckHookParams = {
feature: string | string[];
organization: OrganizationSummary | null;
projectId?: string;
};

/**
* Raw response data from the endpoint
*/
Expand Down Expand Up @@ -90,10 +96,9 @@ export async function promptsCheck(
): Promise<PromptData> {
const query = {
feature: params.feature,
organization_id: params.organization?.id,
...(params.projectId === undefined ? {} : {project_id: params.projectId}),
};
const url = `/organizations/${params.organization?.slug}/prompts-activity/`;
const url = `/organizations/${params.organization.slug}/prompts-activity/`;
const response: PromptResponse = await api.requestPromise(url, {
query,
});
Expand All @@ -112,16 +117,13 @@ export const makePromptsCheckQueryKey = ({
feature,
organization,
projectId,
}: PromptCheckParams): ApiQueryKey => {
}: PromptCheckHookParams): ApiQueryKey => {
const url = `/organizations/${organization?.slug}/prompts-activity/`;
return [
url,
{query: {feature, organization_id: organization?.id, project_id: projectId}},
];
return [url, {query: {feature, project_id: projectId}}];
Comment thread
cursor[bot] marked this conversation as resolved.
};

export function usePromptsCheck(
{feature, organization, projectId}: PromptCheckParams,
{feature, organization, projectId}: PromptCheckHookParams,
{enabled = true, ...options}: Partial<UseApiQueryOptions<PromptResponse>> = {}
) {
return useApiQuery<PromptResponse>(
Expand Down Expand Up @@ -422,7 +424,6 @@ export async function batchedPromptsCheck<T extends readonly string[]>(
): Promise<Record<T[number], PromptData>> {
const query = {
feature: features,
organization_id: params.organization.id,
...(params.projectId === undefined ? {} : {project_id: params.projectId}),
};
const url = `/organizations/${params.organization.slug}/prompts-activity/`;
Expand Down
1 change: 0 additions & 1 deletion ...pp/components/events/interfaces/crashContent/exception/banners/stacktraceBanners.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ describe('StacktraceBanners', () => {
expect.objectContaining({
query: {
feature: 'stacktrace_link',
organization_id: org.id,
project_id: project.id,
},
})
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/events/interfaces/crashContent/exception/banners/stacktraceBanners.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export function StacktraceBanners({stacktrace, event}: StacktraceBannersProps) {
);

const {isLoading, isError, isPromptDismissed, dismissPrompt} = usePrompt({
organization: organization!,
organization,
feature: integrationPromptKey,
projectId: project?.id,
options: {enabled},
Expand Down
Loading