Skip to content

feat(react-router): Use sentryOnError#1255

Merged
chargome merged 7 commits intomasterfrom
cg/rr-onError
Apr 16, 2026
Merged

feat(react-router): Use sentryOnError#1255
chargome merged 7 commits intomasterfrom
cg/rr-onError

Conversation

@chargome
Copy link
Copy Markdown
Member

@chargome chargome commented Apr 9, 2026

implements the new handler introduced in getsentry/sentry-javascript#20120

@chargome chargome self-assigned this Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Features

  • (react-router) Use sentryOnError by chargome in #1255

Bug Fixes

  • (android,flutter) Preserve CRLF line endings when present by andreiborza in #1253

Internal Changes

Deps Dev

  • Bump vite from 7.3.0 to 7.3.2 in /e2e-tests/test-applications/pnpm-workspace-test-app/packages/sveltekit by dependabot in #1250
  • Bump vite from 6.4.1 to 6.4.2 by dependabot in #1252

Other

  • (agents) Convert commands to dotagents skills by chargome in #1236
  • (deps) Bump vite from 6.4.1 to 6.4.2 in /e2e-tests/test-applications/cloudflare-wrangler-sourcemaps-test-app by dependabot in #1251
  • Pin GitHub Actions to full-length commit SHAs by joshuarli in #1244

🤖 This preview updates automatically when you update the PR.

Comment thread src/react-router/react-router-wizard.ts
Comment thread src/react-router/codemods/client.entry.ts
Comment thread src/react-router/react-router-wizard.ts
Comment thread src/react-router/codemods/client.entry.ts Outdated
Comment thread src/react-router/codemods/client.entry.ts
Comment thread src/react-router/codemods/client.entry.ts Outdated
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Comment thread src/react-router/codemods/client.entry.ts Outdated
Comment thread src/react-router/codemods/client.entry.ts
Comment thread src/react-router/codemods/client.entry.ts
@chargome chargome requested review from Lms24 and s1gr1d April 15, 2026 12:56
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm: This works with all RR versions the wizard supports? Or if not, do we check for the required version range and fall back to linking to the manual setup guide?

@chargome
Copy link
Copy Markdown
Member Author

No, thanks for raising, will add a guard!

Comment thread src/react-router/codemods/client.entry.ts
Comment thread src/react-router/codemods/client.entry.ts
Copy link
Copy Markdown
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some general questions: does this work when there is no entry.client.tsx? And why were all the fixtures deleted - don't we need them anymore?

Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3dd25d7. Configure here.

Comment thread src/react-router/templates.ts
@chargome
Copy link
Copy Markdown
Member Author

@s1gr1d the entry.client file is always revealed in the wizard, if not it will throw earlier already. The fixtures got deleted bc we don't capture in the root file anymore so no more changes in there.

@chargome chargome merged commit f252474 into master Apr 16, 2026
57 checks passed
@chargome chargome deleted the cg/rr-onError branch April 16, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants