Repository navigation
fix: Use proto version 2 to fix backfilled user agent and IP - #6256
Conversation
Codecov Results 📊✅ 7 passed | Total: 7 | Pass Rate: 100% | Execution Time: 6.54s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 16879 uncovered lines. Files with missing lines (3)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 22.69% 23.41% +0.72%
==========================================
Files 190 190 —
Lines 21907 22039 +132
Branches 7726 7408 -318
==========================================
+ Hits 4971 5160 +189
- Misses 16936 16879 -57
- Partials 477 478 +1Generated by Codecov Action |
Codecov Results 📊✅ 35 passed | Total: 35 | Pass Rate: 100% | Execution Time: 4.06s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 15952 uncovered lines. Files with missing lines (2)
Generated by Codecov Action |
ingest_settings to fix backfilled user agent and IPThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 75e0c80. Configure here.
…ry#6256) ### Description Turn off user agent and user IP inference in Relay as it doesn't fill in the correct data for backend SDKs. `"version": 2` implies `"ingest_settings": {"infer_ip": "never", "infer_user_agent": "never"}`, as those are the default values for the settings in version 2. I'm not including the values in the item payload to keep it a bit slimmer. Spec: https://develop.sentry.dev/sdk/telemetry/metrics/#version-and-ingest_settings-properties (for metrics, but applies to logs and spans v2 as well; docs rework pending with getsentry/sentry-docs#17725) #### Issues * closes https://linear.app/getsentry/issue/PY-2413/send-ingest-settings * closes getsentry#6255 #### Reminders - Please add tests to validate your changes, and lint your code using `tox -e linters`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)

Description
Turn off user agent and user IP inference in Relay as it doesn't fill in the correct data for backend SDKs.
"version": 2implies"ingest_settings": {"infer_ip": "never", "infer_user_agent": "never"}, as those are the default values for the settings in version 2. I'm not including the values in the item payload to keep it a bit slimmer.Spec: https://develop.sentry.dev/sdk/telemetry/metrics/#version-and-ingest_settings-properties (for metrics, but applies to logs and spans v2 as well; docs rework pending with getsentry/sentry-docs#17725)
Issues
ingest_settings#6255Reminders
tox -e linters.feat:,fix:,ref:,meta:)