Allow setting CRASHPAD_WER_ENABLED when using system crashpad#816
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch I needed to make to add support for the WER module in the conan package: conan-io/conan-center-index#16530
I included the removal of the dependency on crashpad::wer mostly for discussion. With my limited knowledge I think it shouldn't be needed other than maybe for installing? In the conan sentry-crashpad package that target is not exposed and would only be empty I think, since we don't really want the client to link to the lib. Does it make sense to remove it here or should the sentry-crashpad package export an empty target for it?