patch: update test to expect batching thread log message#1612
Merged
JoshuaMoelans merged 2 commits intojoshua/chore/set_default_metrics_truefrom Mar 31, 2026
Merged
Conversation
The batcher thread spawned by metrics startup logs via the custom logger callback, racing with the main thread's writes to assert_now. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpnurmi
approved these changes
Mar 31, 2026
JoshuaMoelans
merged commit 17462a2
into
joshua/chore/set_default_metrics_true
46 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #1609
We keep starting the batcher thread as per usual, but then we need to update this one test case for logging after crash (since the batcher thread itself logs in parallel to whatever goes on in the main process)
simpler alternative to #1611
#skip-changelog