wip: add event attachment download support#346
Closed
seanhoughton wants to merge 1 commit into
Closed
Conversation
379b7d4 to
7bcabc8
Compare
dcramer
reviewed
Jul 5, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
- Coverage 59.37% 58.32% -1.05%
==========================================
Files 49 49
Lines 6038 6263 +225
Branches 472 470 -2
==========================================
+ Hits 3585 3653 +68
- Misses 2453 2610 +157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7bcabc8 to
ae1643a
Compare
Attachments can be listed and downloaded. Text attachments are returned inline with the text response. Binary attachments are included as embedded resource or image content
ae1643a to
6b909e5
Compare
Contributor
Author
Member
|
will work on getting this merged after i land #356 |
Member
|
Alright merged in #358. Thanks @seanhoughton! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Attachments can be listed and downloaded. Text attachments are returned inline with the text response. Binary attachments are included as embedded resource.
This is a prototype implementation to address my feature request: #314. It works very well for small-ish text attachments. I think we should consider a size limit and just return the download URL for anything larger than that limit.
I'm also wondering of we should detect image types and return them as
type: "image"content blocks.I've discovered that VSCode does allow you to download embedded resources, but it's a tiny button that's hidden unless you expand the results of a tool execution. It does not allow you to save the resource to disk as part of the chat.