ref(solidstart): Use core's getTraceMetaTags over own implementation#13274
Merged
andreiborza merged 1 commit intodevelopfrom Aug 8, 2024
Merged
ref(solidstart): Use core's getTraceMetaTags over own implementation#13274andreiborza merged 1 commit intodevelopfrom
andreiborza merged 1 commit intodevelopfrom
Conversation
chargome
reviewed
Aug 8, 2024
|
|
||
| const content = `<head>\n${metaTags.join('\n')}\n`; | ||
| const content = `<head>\n${metaTags}\n`; | ||
| return html.replace('<head>', content); |
Member
There was a problem hiding this comment.
Just wondering what happens if a user has any attributes set on the <head>tag like lang="de" or something like this? 🤔
Member
Author
There was a problem hiding this comment.
Yea then no meta-tags, but I have never seen attributes placed on head ever before. Are there any such cases? (also our other sdks will have this problem too).
Member
There was a problem hiding this comment.
I think it's technically possible although very uncommon
chargome
approved these changes
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #13273