Replay: Dead click false positive

[bruno-garcia]

Clicking on a 'drop down' causes it to show but is detected as false positive:

Example replay link.

SDK version: 7.85.0

[mydea]

Theory: The dropdown is triggered on e.g. mousedown or something like this - some event that is triggered before click. So when we register the click, the mutation already happened, and we think it was a slow click. But this needs to be verified.

[jas-kas]

@mydea @billyvg

Another example: https://sentry.sentry.io/replays/16bd6831e6db4ad4af1dced78793347b/?project=11276&query=dead.selector%3A%22button.en302zp1.app-h1yvkq.e16hd6vm2%5Brole%3D%5C%22button%5C%22%5D%5Baria-label%3D%5C%22%5C%22%5D%5Bdata-test-id%3D%5C%22page-filter-timerange-selector%5C%22%5D%5Balt%3D%5C%22%5C%22%5D%5Btitle%3D%5C%22%5C%22%5D%22&referrer=%2Freplays%2F&statsPeriod=30d&t_main=breadcrumbs&yAxis=count%28%29

We can start looking into this one to confirm the theory?

[jas-kas]

Approaches to resolve this:

• Once we identify the cause, we can update our documentation: troubleshooting entry
• Modification in detection logic

[getsantry]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[bruno-garcia]

This is still happening. In fact these are the top 3 dead clicks in Sentry:

[mydea]

Hmm, I have another clue, found a way to hopefully reduce some more false positives.

Currently, we check for rrweb IncrementalSource.Mutation do determine if something changes. However, there are some more types in there we can check for, which we may also interpret as a mutation:

export declare enum IncrementalSource {
    Mutation = 0,
    MouseMove = 1,
    MouseInteraction = 2,
    Scroll = 3,
    ViewportResize = 4,
    Input = 5,
    TouchMove = 6,
    MediaInteraction = 7,
    StyleSheetRule = 8,
    CanvasMutation = 9,
    Font = 10,
    Log = 11,
    Drag = 12,
    StyleDeclaration = 13,
    Selection = 14,
    AdoptedStyleSheet = 15,
    CustomElement = 16
}

I will extend our check to consider these changes as "DOM mutations":

const IncrementalMutationSources = new Set([
  IncrementalSource.Mutation,
  IncrementalSource.StyleSheetRule,
  IncrementalSource.StyleDeclaration,
  IncrementalSource.AdoptedStyleSheet,
  IncrementalSource.CanvasMutation,
  IncrementalSource.Selection,
  IncrementalSource.MediaInteraction
]);

Importantly, this may also detect some stuff like playing/pausing audio 🤔 not 100% sure if this will fix the problem, but it should def. reduce opportunities for false positives, at least!