Skip to content

deno: Tracing integrations are added with tracing off #23893

Description

@isaacs

deno/src/sdk.ts:46 spreads ...getTracingIntegrations() unconditionally. Node and Bun both gate on hasSpansEnabled(options).

$ deno run -A nospans.mjs      # no tracesSampleRate
tracing OFF -> integration count: 39
... Graphql,Mongo,Mongoose,Mysql,Mysql2,Redis,Postgres,Prisma,Tedious,
GenericPool,Kafka,Amqplib,LruMemoizer,Aws,LangChain,LangGraph,VercelAI,
OpenAI,Anthropic_AI,Google_GenAI,PostgresJs,Firebase,SpanStreaming

On Deno these also subscribe eagerly rather than waiting for the module-injected event (instrumentation.ts:101), so this is real work, not just a longer list.

Work item. Gate getTracingIntegrations() on hasSpansEnabled(options) to match Node and Bun. Confirm first that no Deno integration in that set is relied on for error capture only; if one is, move it to getErrorIntegrations.

**Prior art **(tracked). #22306 (closed) "Automatically pull in all Orchestrion integrations to Deno" is the deliberate decision that produced the unconditional spread. It asked for all server-utils integrations to be pulled in automatically; it did not discuss the hasSpansEnabled gate that Node and Bun apply, which looks like an oversight rather than a choice. No issue covers the gate.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugDenojavascriptPull requests that update javascript code

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions