Add new modules for Spring 7 and Spring Boot 4#4601
Merged
Conversation
Member
Author
This was referenced Aug 4, 2025
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 396.82 ms | 441.67 ms | 44.86 ms |
| ee747ae | 382.73 ms | 435.41 ms | 52.68 ms |
| ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
| ee747ae | 357.79 ms | 421.84 ms | 64.05 ms |
| ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
| ee747ae | 358.21 ms | 389.41 ms | 31.20 ms |
| 674d437 | 355.28 ms | 504.18 ms | 148.90 ms |
| ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
| ee747ae | 374.71 ms | 455.18 ms | 80.47 ms |
| ee747ae | 415.92 ms | 470.15 ms | 54.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 674d437 | 1.58 MiB | 2.10 MiB | 530.94 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
Previous results on branch: 08-04-add_new_modules_for_spring_7_and_spring_boot_4
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 596a7b4 | 381.65 ms | 424.59 ms | 42.95 ms |
| 0deda87 | 378.14 ms | 394.35 ms | 16.20 ms |
| c6da6b0 | 431.38 ms | 494.80 ms | 63.42 ms |
| 0fef848 | 426.67 ms | 455.08 ms | 28.41 ms |
| b969500 | 441.45 ms | 478.17 ms | 36.72 ms |
| 4be2375 | 449.48 ms | 480.81 ms | 31.33 ms |
| e7c4664 | 416.04 ms | 441.27 ms | 25.22 ms |
| b2c2d0b | 414.00 ms | 447.42 ms | 33.42 ms |
| 3b8514c | 403.45 ms | 468.29 ms | 64.84 ms |
| d2060c4 | 432.98 ms | 460.16 ms | 27.18 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 596a7b4 | 1.58 MiB | 2.10 MiB | 533.28 KiB |
| 0deda87 | 1.58 MiB | 2.10 MiB | 533.46 KiB |
| c6da6b0 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| 0fef848 | 1.58 MiB | 2.09 MiB | 522.33 KiB |
| b969500 | 1.58 MiB | 2.10 MiB | 533.46 KiB |
| 4be2375 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| e7c4664 | 1.58 MiB | 2.09 MiB | 521.83 KiB |
| b2c2d0b | 1.58 MiB | 2.09 MiB | 521.57 KiB |
| 3b8514c | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| d2060c4 | 1.58 MiB | 2.10 MiB | 533.25 KiB |
9899937 to
e7a97e5
Compare
7 tasks
e7a97e5 to
3ec789b
Compare
This was referenced Aug 7, 2025
lcian
approved these changes
Aug 8, 2025
Comment on lines
57
to
59
| - sample: "sentry-samples-spring-boot-jakarta" | ||
| agent: "false" | ||
| agent-auto-init: "true" |
Contributor
There was a problem hiding this comment.
is there a reason this sample was not added before to the system-tests-backend (since the sample is not added by this PR)?
Member
Author
There was a problem hiding this comment.
Good catch, this shouldn't be here. It's a duplicate since it's already there:
matrix:
sample: [ "sentry-samples-spring-boot-jakarta" ]
agent: [ "false" ]
agent-auto-init: [ "true" ]
* Fix Spring 7 and Spring Boot 4 modules * Attempt to fix kotlin 2.2 issue * Second attempt to fix Kotlin 2.2 (#4610) * Second attempt to fix Kotlin 2.2 * Format code * Third attempt at fixing Kotlin 2.2 compat (#4613) --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> * Address compose-related issues * Fix tests for Spring 7 and Spring Boot 4 (#4614) * Second attempt to fix Kotlin 2.2 * Format code * Third attempt at fixing Kotlin 2.2 compat * Fix tests for Spring 7 and Spring Boot 4 * Move Spring 7 and Spring Boot 4 packages (#4615) * Move Spring 7 and Spring Boot 4 packages * Fix class not found due to OTel not supporting spring boot 4 yet (#4616) * Format code * some fixes * change kotlin 1.8 to 1.9 and some cleanup * ignore warnings about api level that is not relevant * fix optional dependencies in SentryAutoConfiguration * Update trace origin * Remove duplicate e2e test config * Update Strings for Spring 7 and Spring Boot 4 * Disable Spring Boot 4 agentless e2e tests for now --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io> Co-authored-by: markushi <markus.hintersteiner@sentry.io>
| public SentryInstrumentation sentryInstrumentationWebMvc( | ||
| final @NotNull ObjectProvider<SentryGraphqlInstrumentation.BeforeSpanCallback> | ||
| beforeSpanCallback) { | ||
| SentryIntegrationPackageStorage.getInstance().addIntegration("Spring7GrahQLWebMVC"); |
There was a problem hiding this comment.
Bug: GraphQL Typo in Spring Integration Names
There's a consistent typo in the GraphQL integration names "Spring7GrahQLWebMVC" and "Spring7GrahQLWebFlux" across the new configurations. The "GrahQL" spelling should be "GraphQL", which impacts how these integrations are reported and tracked.
Additional Locations (4)
sentry-spring-boot-4/src/main/java/io/sentry/spring/boot4/graphql/SentryGraphql22AutoConfiguration.java#L30-L31sentry-spring-boot-4/src/main/java/io/sentry/spring/boot4/graphql/SentryGraphqlAutoConfiguration.java#L30-L31sentry-spring-boot-4/src/main/java/io/sentry/spring/boot4/graphql/SentryGraphql22AutoConfiguration.java#L41-L42sentry-spring-7/src/main/java/io/sentry/spring7/graphql/SentryGraphql22Configuration.java#L30-L31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📜 Description
build.gradle.ktsfiles to use the new versions of Spring/Boot in the newly created modules.build.gradle.ktsfiles.💡 Motivation and Context
Initial work for #4080
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps