Metrics not showing in the Sentry Dashboard

[jamescrosswell]

References

• Thread on Discord where I'm trying to get to the bottom of this with the metrics folks.
• Minimal reproduction of the issue
• Valid statsd characters

Problem summary

We don't see all of the metrics in Sentry that we see in Aspire, even though we're listening to all of these.

Aspire has all of these for example:

But in Sentry we're only seeing these:

Solution

It turns out the metric units used by many of the built in metrics include characters that are not valid in statsd.

I've added sanitization for metric units (similar to what we have for keys and values already) so that funky unit names can't break the resulting statsd envelope item.