Serilog LoggingLevelSwitch

[sapsari]

Problem Statement

Due to current API design, we cannot add a Serilog level switch to Sentry sink.

I want something like this:

const Serilog.Events.LogEventLevel sentryMinLevel = Serilog.Events.LogEventLevel.Warning;
static LoggingLevelSwitch sentryLevelSwitch;

var config = new LoggerConfiguration().MinimumLevel.Debug();

config = config.WriteTo.Sink(_sentrySink, sentryMinLevel, sentryLevelSwitch);

Either make class SentrySink public or add an additional argument (of type LoggingLevelSwitch ) to the extension methods.

Solution Brainstorm

No response

[mattjohnsonpint]

For context, here's the method we're talking about:

sentry-dotnet/src/Sentry.Serilog/SentrySinkExtensions.cs

Lines 319 to 339 in f16d8cf

	/// <summary>
	/// Add Sentry sink to Serilog.
	/// </summary>
	/// <param name="loggerConfiguration">The logger configuration.</param>
	/// <param name="configureOptions">The configure options callback.</param>
	public static LoggerConfiguration Sentry(
	this LoggerSinkConfiguration loggerConfiguration,
	Action<SentrySerilogOptions> configureOptions)
	{
	var options = new SentrySerilogOptions();
	configureOptions?.Invoke(options);
	IDisposable? sdkDisposable = null;
	if (options.InitializeSdk)
	{
	sdkDisposable = SentrySdk.Init(options);
	}
	var minimumOverall = (LogEventLevel)Math.Min((int)options.MinimumBreadcrumbLevel, (int)options.MinimumEventLevel);
	return loggerConfiguration.Sink(new SentrySink(options, sdkDisposable), minimumOverall);
	}

Adding an overload that would take a LoggingLevelSwitch parameter and pass it along to Serilog is trivial. That would allow the switch to control the minimum log level of data sent to the Sentry Serilog sink.

However, that won't necessarily provide the desired effect. The MinimumBreadcrumbLevel and MinimumEventLevel values are also passed in the options passed to Sentry's Init method. Thus, changing the level via the switch would not actually change the level Sentry uses.

We would need to go further into the Sentry.Extensions.Logging internals, and provide a mechanism to change the logging level(s) dynamically without re-initalizing the SDK. Then we could wire the switch up to that.

TBH, it's a lot of work for not a lot of value. I'll keep this on the backlog, but we'll likely not get to it any time soon. A PR would be welcome, however. Thanks.

[aiyervenkat]

G'Day Matt,

Hope you are well. I am new to this. I have forked the repo. You mentioned a PR would be welcome. Were referring to just adding the Overload or broader fix by going deeper into Sentry.Extensions.Logging? I would appreciate the clarification.

Thanks
Andy