Skip to content

chore(names): Clarify GraphQL OTel divergence note - #626

Merged
andreiborza merged 2 commits into
mainfrom
feat/graphql-operation-names
Sep 9, 2026
Merged

andreiborza merged 2 commits into
mainfrom
feat/graphql-operation-names

Conversation

@andreiborza

@andreiborza andreiborza commented Sep 7, 2026 •

Copy link
Copy Markdown
Member

What

The GraphQL span name OTel note now shows an example without an operation name.

Why

Operation names are high-cardinality, so span names keep only the operation type.

@github-actions

github-actions Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add sveltekit.* attributes emitted by SvelteKit's native spans by Lms24 in #611
  • Add browser.navigation.type, move navigation.* to router.navigation.* by logaretm in #600
  • Add langchain.chain.name (deprecated) in favor of gen_ai.pipeline.name by RulaKhaled in #599
  • Add browser.paint.type by Lms24 in #606

Descriptions

  • Add more fine grained function.gcp span description rules by Lms24 in #624
  • Add graphql span description rules by Lms24 in #616

Names

  • Add FAAS function span name and description rules by Lms24 in #617
  • Add function span name and description rules by Lms24 in #618
  • Add browser.* span name and description rules by Lms24 in #607
  • Add cache span name rules by Lms24 in #605

Other

  • (op) Add mobile OTA update span operations by antonis in #540
  • (search-attributes) Add search attribute names by nsdeschenes in #610

Bug Fixes 🐛

  • (descriptions) Add graphql-enhanced http.client span description template by Lms24 in #613

Internal Changes 🔧

Deps

  • Bump sharp from 0.35.3 to 0.35.4 by dependabot in #630
  • Bump js-yaml from 4.3.1 to 4.3.2 by dependabot in #631
  • Bump svgo from 4.0.2 to 4.1.0 by dependabot in #627
  • Bump browserslist from 4.28.2 to 4.28.8 by dependabot in #614
  • Bump fast-uri from 3.1.5 to 3.1.7 by dependabot in #612

Names

  • Clarify GraphQL OTel divergence note by andreiborza in #626
  • Add OTel divergence note for graphql span names by Lms24 in #615

Other

  • (deps-dev) Bump vitest from 4.1.9 to 4.1.11 by dependabot in #629
  • (descriptions) Fix http.client span description example by Lms24 in #603

🤖 This preview updates automatically when you update the PR.

@andreiborza
andreiborza marked this pull request as ready for review September 7, 2026 14:29
@andreiborza
andreiborza requested a review from mydea September 7, 2026 14:29
@andreiborza

Copy link
Copy Markdown
Member Author

Otel does warn that these could be high-cardinality, but in practice we've never seen that. I also tried looking through public github repos to see if users define dynamic operations and didn't find any. Happy to close/revise if anyone has more experience with GraphQL and thinks this is a terrible idea.

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally fine with this and happy to approve but I feel like this needs a product-sign-off.

Just one technical suggestion: Let's add a sentence about diverging from the OTel naming schema in otel_notes.

@andreiborza
andreiborza force-pushed the feat/graphql-operation-names branch from 61f3b23 to 9c31e3a Compare September 9, 2026 09:20
@andreiborza andreiborza changed the title feat(names): Include GraphQL operation names in span names chore(names): Clarify GraphQL OTel divergence note Sep 9, 2026
@andreiborza
andreiborza force-pushed the feat/graphql-operation-names branch from 9c31e3a to dbaa9df Compare September 9, 2026 09:22
@andreiborza

Copy link
Copy Markdown
Member Author

After discussions in slack, we came to the conclusion that these could be indeed high-cardinality, especially for public facing graphql api.

So I reworked this PR to just fix the wrong example in the conventions.

@andreiborza
andreiborza merged commit a02233f into main Sep 9, 2026
17 checks passed
@andreiborza
andreiborza deleted the feat/graphql-operation-names branch September 9, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants