Skip to content

chore(descriptions): Fix http.client span description example - #603

Merged
Lms24 merged 2 commits into
mainfrom
lms/chore-descriptions-fix-http.client-example
Aug 31, 2026
Merged

Lms24 merged 2 commits into
mainfrom
lms/chore-descriptions-fix-http.client-example

Conversation

@Lms24

@Lms24 Lms24 commented Aug 31, 2026 •

Copy link
Copy Markdown
Member

Description

http.client span descriptions call for the full URL as a description and not for just the path. The example incorrectly only included the path.

Side-note: Unfortunately, span descriptions will change slightly once they're inferred because SDKs had a dynamic logic to build http.client span descriptions:

  • for same-origin requests, we'd include the relative URL (/users/123?expand=full)
  • for 3rd-party origins, we'd include the full URL (https://example.com/123?expand=full)

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate to generate and format code and docs.

If an attribute was added:

  • The attribute is in a namespace (e.g. nextjs.function_id, not function_id)
  • I have used the correct value for apply_scrubbing (i.e. manual or auto. Use never only for values that should never be scrubbed such as IDs)

If an attribute was deprecated:

@Lms24
Lms24 requested review from a team, cleptric, mjq and nsdeschenes as code owners August 31, 2026 12:05
@github-actions

github-actions Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Internal Changes 🔧

  • (descriptions) Fix http.client span description example by Lms24 in #603

🤖 This preview updates automatically when you update the PR.

@Lms24

Lms24 commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

Gonna merge this for correctness but we likely need a larger conversation for the side-note in the PR

@Lms24
Lms24 enabled auto-merge (squash) August 31, 2026 13:29
@Lms24
Lms24 merged commit cc05c2a into main Aug 31, 2026
17 checks passed
@Lms24
Lms24 deleted the lms/chore-descriptions-fix-http.client-example branch August 31, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants