fix(names): Include tool name in gen_ai.execute_tool span names - #580
Merged
Merged
Conversation
Tool execution spans carry `gen_ai.tool.name` rather than a model, so the existing templates could only name them `execute_tool`. Add a tool name template so they get a name that identifies the tool. Co-Authored-By: Claude <noreply@anthropic.com>
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Names
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Lms24
marked this pull request as ready for review
August 26, 2026 15:38
Lms24
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
August 26, 2026 15:38
nsdeschenes
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_ai.execute_toolspans carrygen_ai.tool.nameand no model, so the current templates can only name themexecute_tool. This PR adds a{{gen_ai.operation.name}} {{gen_ai.tool.name}}template, which matches what the JS and Python SDKs named these spans (changing this pending on this PR)I think, tool names should be low cardinality enough to include in span names but happy to drop if I'm missing something.