feat(span-names): Add url.domainrule for http.client spans - #575
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2caaad3. Configure here.
mjq
left a comment
There was a problem hiding this comment.
For completeness: as mentioned in Slack there's a possibility of unlimited cardinality here via subdomains, but I think this is a more useful default, doesn't particularly have infrastructure implications, and users can override the names in an SDK hook if they have a use case with high-cardinality subdomains they'd prefer to be grouped. 👍

This PR proposes adding another name generation rule to
http.clientspans: If we cannot find a parameterized URL matching the first two rules (which is almost always the case in JS at least), we can construct the name based onto include at least a bit more information than just the method. Would appreciate product input if this is an acceptable level of cardinality!