Skip to content

feat(span-names): Add url.domainrule for http.client spans - #575

Merged
Lms24 merged 4 commits into
mainfrom
lms/feat-names-http-client
Aug 27, 2026
Merged

Lms24 merged 4 commits into
mainfrom
lms/feat-names-http-client

Conversation

@Lms24

@Lms24 Lms24 commented Aug 25, 2026 •

Copy link
Copy Markdown
Member

This PR proposes adding another name generation rule to http.client spans: If we cannot find a parameterized URL matching the first two rules (which is almost always the case in JS at least), we can construct the name based on

{{http.request.method}} {{url.domain}}

to include at least a bit more information than just the method. Would appreciate product input if this is an acceptable level of cardinality!

@github-actions

github-actions Bot commented Aug 25, 2026 •

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (attributes) Add graphql.processing.type by andreiborza in #572
  • (span-names) Add url.domainrule for http.client spans by Lms24 in #575

Bug Fixes 🐛

  • (names) Correct graphql span name examples by andreiborza in #573

Internal Changes 🔧

  • (attributes) Add search alias for segment name by nsdeschenes in #577

🤖 This preview updates automatically when you update the PR.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2caaad3. Configure here.

Comment thread python/uv.lock Outdated
@Lms24 Lms24 self-assigned this Aug 25, 2026
@Lms24
Lms24 marked this pull request as ready for review August 25, 2026 14:19
@Lms24
Lms24 requested review from a team, cleptric, mjq and nsdeschenes as code owners August 25, 2026 14:19
Comment thread model/name/http.json Outdated

@mjq mjq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness: as mentioned in Slack there's a possibility of unlimited cardinality here via subdomains, but I think this is a more useful default, doesn't particularly have infrastructure implications, and users can override the names in an SDK hook if they have a use case with high-cardinality subdomains they'd prefer to be grouped. 👍

@Lms24
Lms24 enabled auto-merge (squash) August 27, 2026 10:48
@Lms24
Lms24 merged commit 0524a6b into main Aug 27, 2026
16 checks passed
@Lms24
Lms24 deleted the lms/feat-names-http-client branch August 27, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants