fix(names): Correct graphql span name examples - #573
Merged
Merged
Conversation
The examples were `mutation` and `query`, which no template can produce since Sentry prefixes GraphQL span names with `GraphQL `. They predate that prefix. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013bjBXkGkJo8eL8hkz48byi
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
andreiborza
marked this pull request as ready for review
August 24, 2026 18:45
andreiborza
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
August 24, 2026 18:45
mjq
approved these changes
Aug 24, 2026
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
graphqlspan name examples aremutationandquery, which neither template can produce: Sentry prefixes GraphQL span names withGraphQL, as theotel_noteson the same entry says. They predate that prefix.Replaces them with names the templates actually produce, and includes the static fallback, matching how sibling name conventions list their examples (
browser.jsonlistsPageload,db.jsonlistsDatabase operation).No template or behavior change.
PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.https://claude.ai/code/session_013bjBXkGkJo8eL8hkz48byi