Draft
Conversation
Puppeteer's bundled Chromium download was causing the yarn install step to exceed the 10-minute timeout. Use browser-actions/setup-chrome instead and point puppeteer at the system-installed Chrome binary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Puppeteer's Chromium downloads need more time after the yarn.lock changes in the vite/vitest bump. Revert the setup-chrome approach since puppeteer v17/v20 need their own bundled Chromium revisions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Vitest 2 dynamically imports jsdom even when tests don't use the jsdom environment, causing unhandled errors that fail the test run. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… timeout
jsdom 29 formats cssText with spaces inside braces (e.g.
`div { color: black; }` instead of `div {color: black;}`).
Use toContain for CSS assertions to be resilient to formatting.
Also increase timeout for the iframe stylesheet loading test which
is slow in CI.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not use this package internally and it just pulls in a bunch of deps that we do not need.