fix(tracemetrics): Update pii scrubbing#5815
Merged
Conversation
This updates pii scrubbing to use the eap pii scrub package just like scrub_log does now, and adds some more tests to ensure pii scrubbing is happening properly before we add UI.
jjbayer
approved these changes
Apr 13, 2026
Dav1dde
approved these changes
Apr 13, 2026
Member
Dav1dde
left a comment
There was a problem hiding this comment.
For assertion we started more and more to go towards asserting the entire items, or bigger keys of an item, for example in this ourlogs test:
relay/tests/integration/test_ourlogs.py
Lines 505 to 533 in b8f863f
This often is barely more lines of code, but it is also less error prone (e.g. no need to check the length/size to check for additional keys) and it covers more regression cases.
48d014d to
b0ec7b9
Compare
cae0ace to
e989af9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates pii scrubbing to use the eap pii scrub package just like scrub_log does now, and adds some more tests to ensure pii scrubbing is happening properly before we add UI.